Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(drawer): infinite loop when two-way opened binding is toggled mid-animation #8872

Merged
merged 1 commit into from
Dec 13, 2017
Merged

fix(drawer): infinite loop when two-way opened binding is toggled mid-animation #8872

merged 1 commit into from
Dec 13, 2017

Commits on Dec 7, 2017

  1. fix(drawer): infinite loop when two-way opened binding is toggled mid… 

    …-animation

As of angular@004e0fe the drawer supports a two-way binding on the `opened` property, however because the `openedChange` emits at the end of the animation and two-way bindings invoke their setter which then trigger an animation which in turn invokes `openedChange`, there is the potential for an infinite loop if the user changes the `opened` state mid-animation. These changes avoid the issue by turning the `openedChanged` into an async stream and emitting the current value at the end of the animation, rather than determining the value based on the animation state.

Fixes angular#8869.
    @crisbeto
    crisbeto committed Dec 7, 2017
    Configuration menu
    Copy the full SHA
    278e191 View commit details
    Browse the repository at this point in the history