Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source map path in npm release causing warnings #227

Closed
Londovir opened this issue Mar 19, 2017 · 4 comments
Closed

Source map path in npm release causing warnings #227

Londovir opened this issue Mar 19, 2017 · 4 comments
Assignees
Milestone

Comments

@Londovir
Copy link

For 2.0.0-rc.1, the official package pulled down from npm has most of the compiled JavaScript files ending with a terminating #sourceMappingURL element bearing what appears to be a path to one of the author's folders. Namely, /usr/local/google/home/mmalerba/flex-layout/src/lib.... This causes most of my tooling (including webpack if an angular-cli project using this flex-layout is later ejected) to throw off a ton of warnings because the sourcemap url is invalid. These warnings also collect in Chrome's developer panel as well when Chrome attempts to load symbols from the sourcemaps.

Based upon other npm packages, it would seem the pathing shouldn't be included in the distribution so that the associated sourcemap provided in the package can be loaded.

@ThomasBurleson
Copy link
Contributor

@mmalerba - I think we still need the #sourcMappingURL; but at least it should be a relative URL. any thoughts? I

@mmalerba
Copy link
Contributor

@hansl Do you know why these are being generated with an absolute path?

crisbeto added a commit to crisbeto/flex-layout that referenced this issue Apr 12, 2017
* Bumps all of the `@angular` dependencies to 4 and Material to 2.0.0-beta.3.
* Fixes a few linter errors.
* Fixes an issue that prevented AoT from working under Angular 4.
* Moves away from a few of the APIs that were deprecated in Angular 4.
* Fixes issues with the testing setup which prevented the module from compiling with Angular 4.
* Fixes the demo app not working properly due to the Material theme not being included correctly.

Fixes angular#254, angular#236, angular#227.
crisbeto added a commit to crisbeto/flex-layout that referenced this issue Apr 12, 2017
* Bumps all of the `@angular` dependencies to 4 and Material to 2.0.0-beta.3.
* Fixes a few linter errors.
* Fixes an issue that prevented AoT from working under Angular 4.
* Moves away from a few of the APIs that were deprecated in Angular 4.
* Fixes issues with the testing setup which prevented the module from compiling with Angular 4.
* Fixes the demo app not working properly due to the Material theme not being included correctly.

Fixes angular#254, angular#236, angular#227.
kara pushed a commit that referenced this issue Apr 18, 2017
karlhaas pushed a commit to karlhaas/flex-layout that referenced this issue May 3, 2017
karlhaas pushed a commit to karlhaas/flex-layout that referenced this issue May 3, 2017
@ThomasBurleson
Copy link
Contributor

Closing as not valid with Angular 4.1.x and beta.8

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants