Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning npm installing the latest flex-layout #254

Closed
pdjota opened this issue Apr 12, 2017 · 1 comment · Fixed by #255
Closed

Warning npm installing the latest flex-layout #254

pdjota opened this issue Apr 12, 2017 · 1 comment · Fixed by #255
Labels
has pr A PR has been created to address this issue
Milestone
v2.0.0-beta.8

Comments

@pdjota
Copy link

pdjota commented Apr 12, 2017

Bug Report

Repro steps

  1. Generate a new project with @angular/cli, e.g. ng new example
  2. Install flex-layout
    Expected result:
    Package installs successfully.

Actual result:
Package installs with warnings:

➤ npm i -S @angular/flex-layout
example@0.0.0 /Users/pdejuan/projects/101/ngcourses/example
└── @angular/flex-layout@2.0.0-beta.7 

npm WARN @angular/flex-layout@2.0.0-beta.7 requires a peer of @angular/common@^2.3.5 but none was installed.
npm WARN @angular/flex-layout@2.0.0-beta.7 requires a peer of @angular/core@^2.3.5 but none was installed.
npm WARN @angular/flex-layout@2.0.0-beta.7 requires a peer of zone.js@^0.7.2 but none was installed.

Suggestion:
Update dependencies in the build
https://github.com/angular/flex-layout-builds/blob/master/package.json
To be updated to Angular 4.0.2

"peerDependencies": {
"@angular/common": "^2.3.5",
"@angular/core": "^2.3.5",
"rxjs": "^5.0.1",
"zone.js": "^0.7.2"
}
@pdjota pdjota mentioned this issue Apr 12, 2017
Closed
@crisbeto crisbeto mentioned this issue Apr 12, 2017
Merged
crisbeto added a commit to crisbeto/flex-layout that referenced this issue Apr 12, 2017
@crisbeto
fix(build): support Angular 4 and AOT
aa67910 
* Bumps all of the `@angular` dependencies to 4 and Material to 2.0.0-beta.3.
* Fixes a few linter errors.
* Fixes an issue that prevented AoT from working under Angular 4.
* Moves away from a few of the APIs that were deprecated in Angular 4.
* Fixes issues with the testing setup which prevented the module from compiling with Angular 4.
* Fixes the demo app not working properly due to the Material theme not being included correctly.

Fixes angular#254, angular#236, angular#227.
crisbeto added a commit to crisbeto/flex-layout that referenced this issue Apr 12, 2017
@crisbeto
fix(build): support Angular 4 and AOT
7cd336b 
* Bumps all of the `@angular` dependencies to 4 and Material to 2.0.0-beta.3.
* Fixes a few linter errors.
* Fixes an issue that prevented AoT from working under Angular 4.
* Moves away from a few of the APIs that were deprecated in Angular 4.
* Fixes issues with the testing setup which prevented the module from compiling with Angular 4.
* Fixes the demo app not working properly due to the Material theme not being included correctly.

Fixes angular#254, angular#236, angular#227.
@ThomasBurleson ThomasBurleson added this to the v2.0.0-beta.8 milestone Apr 14, 2017
@ThomasBurleson ThomasBurleson added the has pr A PR has been created to address this issue label Apr 14, 2017
@kara kara closed this as completed in #255 Apr 18, 2017
kara pushed a commit that referenced this issue Apr 18, 2017
@crisbeto @kara
fix(build): support Angular 4 and AOT (#255)
fed87fa 
Fixes #254, #236, #227.
karlhaas pushed a commit to karlhaas/flex-layout that referenced this issue May 3, 2017
@crisbeto @karlhaas
fix(build): support Angular 4 and AOT (angular#255)
9c3372e 
Fixes angular#254, angular#236, angular#227.
karlhaas pushed a commit to karlhaas/flex-layout that referenced this issue May 3, 2017
@crisbeto @karlhaas
fix(build): support Angular 4 and AOT (angular#255)
221bfa7 
Fixes angular#254, angular#236, angular#227.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
has pr A PR has been created to address this issue
Projects
None yet
Milestone
v2.0.0-beta.8
Development

Successfully merging a pull request may close this issue.

fix(build): support Angular 4 and AOT crisbeto/flex-layout
2 participants
@pdjota @ThomasBurleson