-
Notifications
You must be signed in to change notification settings - Fork 772
feat(core): add print support with mediaQuery override #954
Conversation
@CaerusKaru - these include changes from PRs #946 and #912. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the approach overall. Some things missing or need to be added.
Also, scope should be |
6a8c59a
to
8e5f762
Compare
CLAs look good, thanks! |
735f6e1
to
72998b2
Compare
9c31ffa
to
21e68b5
Compare
0c60244
to
60d3153
Compare
4baee25
to
a386fed
Compare
bff6040
to
4b798a0
Compare
9c80f62
to
631f2fd
Compare
@CaerusKaru - final quick review plz? Ready to merge after your lgtm. |
b3af138
to
29b0c2d
Compare
29b0c2d
to
febc7a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes, otherwise very close
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
aaf27c5
to
67e78b3
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Implement PrintHook service to intercept print mediaQuery activation events.
printWithBreakpoint
FlexLayoutModule.withConfig()
to merge overrides with defaultsfxShow.print
andfxHide.print
Example:
Using the new
printWithBreakpoint
allows developers to specify a breakpoint that should be used to render layouts only during printing. With the configuration below, the breakpoint associated with themd
alias will be used.Shown below is the print layout rendered in floating dialog over the normal layout using 'lg' breakpoints. The printed version uses:
fxHide.print
to hide the buttons, and a demofxShow.print
to show a watermark overlayFixes #603.