Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update UI for email confirmation #812

Closed
wants to merge 4 commits into from

Conversation

SHITIZ-AGGARWAL
Copy link
Contributor

Description

updating user interface for email confirmation

Fixes #768

Type of Change:

  • User Interface

Checklist:

  • Design a specific UI for email confirmation

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #812 into develop will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #812      +/-   ##
===========================================
- Coverage    95.84%   95.84%   -0.01%     
===========================================
  Files           95       95              
  Lines         5200     5199       -1     
===========================================
- Hits          4984     4983       -1     
  Misses         216      216              
Impacted Files Coverage Δ
app/database/models/user.py 98.57% <0.00%> (-0.03%) ⬇️

Copy link
Contributor

@SanketDG SanketDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaurivn Is this what was expected of the issue?

Also, please don't assign someone issues if they are already assigned.

@gaurivn
Copy link
Member

gaurivn commented Sep 1, 2020

Also, please don't assign someone issues if they are already assigned.

I've always checked that before assigning, will take care.. in some cases they got assigned to other issues after I assigned them. And design PRs do take a lot more time to get approved.

@gaurivn
Copy link
Member

gaurivn commented Sep 1, 2020

@anitab-org/design-team, please review this PR.

@gaurivn Is this what was expected of the issue?

Not completely, changes will be required, I've tagged the design team to help for same.

@gaurivn
Copy link
Member

gaurivn commented Sep 5, 2020

@SHITIZ-AGGARWAL, by updating UI, you'll have to design a mock for the same, please refer this PR for a similar issue.

@SHITIZ-AGGARWAL
Copy link
Contributor Author

sure , got it , I will make the required changes

@SHITIZ-AGGARWAL
Copy link
Contributor Author

@gaurivn please help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design UI for email confirmation
3 participants