Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: updated mentorship relation accepted mock and added it #828

Closed
wants to merge 1 commit into from

Conversation

vj-codes
Copy link
Member

@vj-codes vj-codes commented Sep 3, 2020

Description

Added UI mock so that I can get reviews and then proceed to code it.

Fixes #769

Type of Change:

  • User Interface
  • Documentation

Screenshot of mock -
image

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #828 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #828   +/-   ##
========================================
  Coverage    95.84%   95.84%           
========================================
  Files           95       95           
  Lines         5200     5200           
========================================
  Hits          4984     4984           
  Misses         216      216           

Copy link
Contributor

@SanketDG SanketDG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I am hoping @isabelcosta will provide more insights on the copy.

@gaurivn gaurivn mentioned this pull request Sep 5, 2020
1 task
@vj-codes vj-codes added Status: Needs Review PR needs an additional review or a maintainer's review. First Timers Only Good for newcomers. labels Nov 4, 2020
@isabelcosta
Copy link
Member

@vj-codes thank you for participating on OSH!
I'll close the issue as we're going to discuss designs for emails altogether and then implement changes. I will add this PR to our Wiki :)

@vj-codes vj-codes deleted the OSHui branch April 12, 2021 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First Timers Only Good for newcomers. Status: Needs Review PR needs an additional review or a maintainer's review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design UI for Mentorship relation accepted
3 participants