Consts #17431
Open
Consts #17431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allo to remove else in `when` case, and generally improve typing. Also, allows to remove some constant that were duplicate of the enum entries.
Imporves typing
This improve the typing.
createCustomStudySession was taking an array with 3 elements, two being a Dyn. I change it to take explicitly three parameters for typing purpose.
Improve typing
Arthur-Milchior
force-pushed
the
CONSTS
branch
from
5a067d4
to
053f251
Compare
david-allison
added
the
Blocked by dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be merged after #17430. It contains #17430 and removing #17430 would create a ton of merge conflict.
It transforms IntDef of Consts.kt into enum