Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consts #17431

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Consts #17431

wants to merge 5 commits into from

Commits on Nov 12, 2024

  1. NF: Use com.ichi2.anki.Ease as much as possible 

    This allo to remove else in `when` case, and generally improve
typing. Also, allows to remove some constant that were duplicate of
the enum entries.
    @Arthur-Milchior
    Arthur-Milchior committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    bd515d1 View commit details
    Browse the repository at this point in the history

  2. NF: CardType is a enum class 

    Imporves typing
    @Arthur-Milchior
    Arthur-Milchior committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    c8e4722 View commit details
    Browse the repository at this point in the history

  3. NF: QueueType becomes an enum 

    This improve the typing.
    @Arthur-Milchior
    Arthur-Milchior committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    2dd9a03 View commit details
    Browse the repository at this point in the history

  4. NF: Dyn is an enum 

    createCustomStudySession was taking an array with 3 elements, two
being a Dyn. I change it to take explicitly three parameters for
typing purpose.
    @Arthur-Milchior
    Arthur-Milchior committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    6bc3e6f View commit details
    Browse the repository at this point in the history

  5. NF: ModelType is an enum 

    Improve typing
    @Arthur-Milchior
    Arthur-Milchior committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    053f251 View commit details
    Browse the repository at this point in the history