NF: Use enum for flag everywhere possible #17434
Open
+147
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrayanDSO
requested changes
Nov 14, 2024
BrayanDSO
added
the
Needs Author Reply
It should be added that there is some ambiguity for the value of the flag. A flag could be either between 0 and 7, or an arbitrary int whose first 3 digits are the displayed flags. Actually, the only time a number greater than 7 is generated, it's stored into the card's `flags` field, and never leave this object. So it's okay to use `Flag` object everywhere else.
Arthur-Milchior
force-pushed
the
flag
branch
from
425355c
to
894520c
Compare
BrayanDSO
approved these changes
Nov 15, 2024
BrayanDSO
added
Needs Second Approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be added that there is some ambiguity for the value of the flag. A flag could be either between 0 and 7, or an arbitrary int whose first 3 digits are the displayed flags.
Actually, the only time a number greater than 7 is generated, it's stored into the card's
flagsfield, and never leave this object. So it's okay to useFlagobject everywhere else.