Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to FSRS-rs v0.6.1 #3106

Merged
merged 10 commits into from
Apr 5, 2024
Merged

Conversation

L-M-Sherlock
Copy link
Contributor

@L-M-Sherlock L-M-Sherlock commented Mar 31, 2024

@RlzHi
Copy link

RlzHi commented Mar 31, 2024

Looks good

@L-M-Sherlock L-M-Sherlock changed the title Update to FSRS-rs v0.6.0 Update to FSRS-rs v0.6.1 Apr 2, 2024
@L-M-Sherlock
Copy link
Contributor Author

These tooltips should also update. @Expertium, @user1823, any suggestion?

deck-config-weights-tooltip =
FSRS parameters affect how cards are scheduled. Anki will start with default parameters. Once
you've accumulated 1000+ reviews, you can use the option below to optimize the parameters to best
match your performance in decks using this preset.

deck-config-compute-optimal-weights-tooltip =
Once you've done 1000+ reviews in Anki, you can use the Optimize button to analyze your review history,
and automatically generate parameters that are optimal for your memory and the content you're studying.
If you have decks that vary wildly in difficulty, it is recommended to assign them separate presets, as
the parameters for easy decks and hard decks will be different. There is no need to optimize your parameters
frequently - once every few months is sufficient.

@Expertium
Copy link
Contributor

I suggest just replacing 1000 with 8. Also, the same needs to be done with the "insufficient review history" error message.

@L-M-Sherlock
Copy link
Contributor Author

I suggest just replacing 1000 with 8. Also, the same needs to be done with the "insufficient review history" error message.

The user still could click optimize to get the default parameters when the number of reviews is lower than 8. It's more important to explain which reviews are counted. Assuming a new user does 1000 reviews in a deck of new cards, the optimize button still pop up the insufficient data error because those reviews are the first review of each cards. The first four parameters are pretrained in the second review of each card, and the rest params are trained in the third and following reviews of each card.

@dae
Copy link
Member

dae commented Apr 3, 2024

Maybe one option would be to stop showing an error, and just fall back on the default parameters instead?

@Expertium
Copy link
Contributor

That would be quite simple, which is nice, but it could cause confusion. If the user clicks "Optimize" and parameters don't change, he will think that the optimizer is broken.

@dae
Copy link
Member

dae commented Apr 3, 2024

If we don't change anything, we can keep showing the message that the parameters are currently optimal.

@brishtibheja
Copy link
Contributor

brishtibheja commented Apr 4, 2024

Is there any specific reason why the parameters need to be shown to users? That section also looks quite cluttered in the Android app so one less thing there if it's not shown.

@dae
Copy link
Member

dae commented Apr 4, 2024

Some power users like to be able to see and/or modify them.

@Expertium
Copy link
Contributor

@dae, do you plan to release 24.04.1 after you merge this pull request?

@dae
Copy link
Member

dae commented Apr 4, 2024

.1 will be a quick update with only some bugfixes, so I wasn't planning to include this. There may be a .2 if we have a longer testing period to try it out.

@dae
Copy link
Member

dae commented Apr 5, 2024

Thanks @L-M-Sherlock. This will go into the main branch, but probably not into the 24.04.1 branch.

@dae dae merged commit 10d567f into ankitects:main Apr 5, 2024
1 check passed
@L-M-Sherlock L-M-Sherlock deleted the update-to-FSRS-rs-0.6.0 branch April 5, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FSRS - Research suggests the minimum limit can be reduced to 16
6 participants