Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove stratified kfold #173

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Remove stratified kfold #173

merged 2 commits into from
Apr 2, 2024

Conversation

L-M-Sherlock
Copy link
Member

I removed n_splits in this PR because it doesn't improve the accuracy of FSRS. It will make the optimization 3~4x faster.

Related PR:

@L-M-Sherlock L-M-Sherlock added the enhancement New feature or request label Apr 2, 2024
@L-M-Sherlock L-M-Sherlock merged commit 7d27226 into main Apr 2, 2024
3 checks passed
@L-M-Sherlock L-M-Sherlock deleted the remove-stratified_kfold branch April 2, 2024 06:10
@L-M-Sherlock L-M-Sherlock mentioned this pull request Apr 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asukaminato0721 asukaminato0721 asukaminato0721 approved these changes

@dae dae Awaiting requested review from dae

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@L-M-Sherlock @asukaminato0721