fix sveltekit respecting yarn env var #3226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I seem to recall there was a reason why it was changed, but since the build seems to work fine now without ./yarn, I'm not sure what the reason was. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the replacement of Svelte with SvelteKit I've noticed how anki can no longer build successfully when using the env var
YARN_BINARY.Investigating a bit, I’ve noticed how in
build/ninja_gen/src/node.rs, the function in question has./yarnhardcoded in as opposed to reading in the env var if appropriate.This PR reads-in the yarn variable for
SveltekitBuildin the same manner as it already does for the other functions.