Make SvelteCheck and ViteTest respect YARN_BINARY
#3231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No objections to the other changes, but ./yarn(.bat) is useful for when the user does not have node installed globally. It allows running things like './yarn dev' without having to manually put out/extracted/node on the path first. |
|
Sorry for the inactivity, I now implemented your feedback! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is kind of a follow up to #3226. It allows me to run the tests fully offline in the Gentoo Linux package.
I removed the
./yarn{,.bat}files in the build system along with all references to them, since they seem to be no longer needed.Checks pass locally on Linux and I hope that Windows CI passes, too, since I didn't set up a Windows VM to test this.