Feat/FSRS-5 #3298
Feat/FSRS-5 #3298
Conversation
|
@dae, I have some problems with the CI. Could you help me? |
|
Sorry, please let me know if you see them again in the future. I had to manually remove some files |
| @@ -23,6 +23,7 @@ allow = [ | |||
| "CC0-1.0", | |||
| "Unlicense", | |||
| "Zlib", | |||
| "Unicode-3.0", | |||
There was a problem hiding this comment.
@dae, I added this line to solve the problem. Is it acceptable?
There was a problem hiding this comment.
Oops, I get a new error:
error[custom]: unknown term
| ┌─ /state/build/lin-ci/ankitects/anki-ci/.deny.toml:26:4
| │
| 26 │ "Unicode-3.0",
| │ ^^^^^^^^^^^
|
| 2024-07-15 12:39:03 [ERROR] failed to deserialize config from '/state/build/lin-ci/ankitects/anki-ci/.deny.toml'
There was a problem hiding this comment.
Confusing, https://github.com/EmbarkStudios/cargo-deny/blob/6344cc566621410a0865632b4ef0e82a20408676/deny.template.toml#L89C7-L89C33 said it's spdx license, but "Unicode-3.0" is spdx format.
There was a problem hiding this comment.
oh, this may be the problem. https://github.com/EmbarkStudios/spdx/pull/65/files#diff-94815ebc8dd748656c1a4414adabdbbc8eeefcf0e1b1fc069223bbdf8bf08974R1843 it's new added.
There was a problem hiding this comment.
well,
the 3.0 available from spdx 0.10.4
cargo deny uses "0.10", so I guess here is the problem.
from the log,
Ignored package `cargo-deny v0.14.12` is already installed, use --force to override
release 5 month ago. The problem is clear now.
There was a problem hiding this comment.
I guess install the latest cargo-deny could fix this. Which is now 0.14.24.
There was a problem hiding this comment.
Yes, all good now - thank you both.
|
@dae, this PR is ready for review. |
|
hyped for fsrs5 |
|
Sorry for the delay. Looks good to me - thank you for all your work on this! |
TODO:
get_optimal_retention_parametersto adapt theSimulatorConfigof FSRS-5 Python Codefix #3270