Possible to show “last” subdeck name in Browser? #3387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Ben. I think this would be a bit cleaner (but a slightly larger change) if Cell were extended to include an enum specifying the eliding mode, so that paint doesn't need to do a string comparison on the column name. BrowserRow will need updating in search.proto, and Cell will need updating in the Python. @RumovZ is the author of this code though, and I'll happily defer to him if feels it should be done differently. |
|
Thanks for the feedback. I won't be able to look back into this for the next two weeks, so if someone else wants to take it in the meantime feel free to :) |
Completely agree. |
|
Still available :-) |
|
I am back on it! |
…to elide-middle
…to elide-middle
|
Hopefully this is cleaner |
|
Looks good - thanks Ben! |
twwn
added a commit
to twwn/anki
that referenced
this pull request
Sep 22, 2024
* master: Update translations Add an option to show image from editor in folder (ankitects#3412) Call the profile_did_open() hook earlier (ankitects#3421) Fix FSRS progress update issues (ankitects#3420) Update tooltip text (ankitects#3418) Fix pasting from the primary selection (ankitects#3413) Fix occlusion rounding bug (ankitects#3400) Add comment about the usage of the input field in the statistics page (ankitects#3394) (ankitects#3398) Possible to show “last” subdeck name in Browser? (ankitects#3387)
twwn
pushed a commit
to twwn/anki
that referenced
this pull request
Sep 22, 2024
* elide middle of deck names * Update CONTRIBUTORS * made elide mode enum * add elide mode field * fix enum number * remove dataclass decorator * Update CONTRIBUTORS * format rust code * Update CONTRIBUTORS * formatting * Update CONTRIBUTORS * fix type hint * Update CONTRIBUTORS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3348