Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment about the usage of the input field in the statistics page (#3394) #3398

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

lukesbart
Copy link
Contributor

Resolve #3394 which requested that a comment be added to describe the usage of the input form in the statistics page in external apps.

@dae
Copy link
Member

dae commented Sep 10, 2024

Thanks for contributing! I've posted a comment on the original issue: ankidroid/Anki-Android#15648 (comment)

@mikehardy
Copy link
Contributor

I unblocked our PR despite the brittle "twiddle first text box" current state as it appears we will have some form of resolution here but it'll take a while for whatever it is to flow downstream.

Just for completeness, cross-link --> ankidroid/Anki-Android#17075

dae and others added 2 commits September 20, 2024 20:35
Co-authored-by: Mike Hardy <github@mikehardy.net>
Co-authored-by: Mike Hardy <github@mikehardy.net>
@dae
Copy link
Member

dae commented Sep 20, 2024

I've tweaked the id name to be less likely to conflict

@dae dae merged commit 1b7123a into ankitects:main Sep 20, 2024
1 check was pending
twwn added a commit to twwn/anki that referenced this pull request Sep 22, 2024
* master:
  Update translations
  Add an option to show image from editor in folder (ankitects#3412)
  Call the profile_did_open() hook earlier (ankitects#3421)
  Fix FSRS progress update issues (ankitects#3420)
  Update tooltip text (ankitects#3418)
  Fix pasting from the primary selection (ankitects#3413)
  Fix occlusion rounding bug (ankitects#3400)
  Add comment about the usage of the input field in the statistics page (ankitects#3394) (ankitects#3398)
  Possible to show “last” subdeck name in Browser? (ankitects#3387)
twwn pushed a commit to twwn/anki that referenced this pull request Sep 22, 2024
…ankitects#3394) (ankitects#3398)

* Add comment about the usage of the input field in the statistics page (ankitects#3394)

* Fix formatting issues (ankitects#3394)

* Update ts/routes/graphs/RangeBox.svelte

Co-authored-by: Mike Hardy <github@mikehardy.net>

* Update ts/routes/graphs/RangeBox.svelte

Co-authored-by: Mike Hardy <github@mikehardy.net>

---------

Co-authored-by: Damien Elmes <dae@users.noreply.github.com>
Co-authored-by: Mike Hardy <github@mikehardy.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request to add a comment for the input field in the statistics page
3 participants