Migrate rds_cluster* modules and tests #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
@alinabuzachis: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
ansibullbot
added
integration
alinabuzachis
changed the title
gravesm
approved these changes
Sep 16, 2022
abikouo
reviewed
Sep 21, 2022
abikouo
reviewed
Sep 21, 2022
tests/integration/targets/rds_cluster/roles/rds_cluster/tasks/main.yml
Outdated
Show resolved
Hide resolved
abikouo
approved these changes
Sep 21, 2022
alinabuzachis
force-pushed
the
promote_rds_cluster
branch
from
7a5e33f
to
f2afd44
Compare
alinabuzachis
force-pushed
the
promote_rds_cluster
branch
from
f2afd44
to
ba16fc7
Compare
ansibullbot
added
needs_rebase
|
regate |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
ansibullbot
added
needs_rebase
goneri
force-pushed
the
promote_rds_cluster
branch
from
a5e07a6
to
4d3d5e6
Compare
|
regate |
goneri
force-pushed
the
promote_rds_cluster
branch
from
4d3d5e6
to
978c28f
Compare
|
regate |
ansibullbot
removed
needs_rebase
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
New modules for RDS clusters management SUMMARY Two new modules for RDS clusters management (rds_cluster ans rds_cluster_info) Took over from: ansible-collections#262 Depends-On: ansible-collections#553 Closes ansible-collections#849 Should also close ansible-collections#191 ISSUE TYPE New Module Pull Request Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@3661b1c
…ent meta data (ansible-collections#1090) For consistency - add empty dependencies file to targets with no current meta data SUMMARY For consistency - add empty dependencies file to targets with no current meta data ISSUE TYPE Feature Pull Request COMPONENT NAME tests/integration/targets ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@9638580
…le-collections#1081) rds_instance - add snapshot tests, update docs, refactor tests Depends-On: ansible-collections#776 Depends-On: ansible-collections#1105 SUMMARY add snapshot tests to test restoring db from snapshot and fix bugs associated fix some typos in documentation and remove duplicate parameter (added as alias so no breaking change) remove unused IAM role in tests and add some missing cleanups ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION this module had both db_snapshot_identifier and snapshot_identifier as separate params, with the latter being required to restore from snapshot, resulting in some parameter missing errors. moving snapshot_identifier as an alias of db_snapshot_identifier fixes this issue. Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Sloane Hertel <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@5d5bca9
…sible-collections#1182) Tagging fragment - Move simplest cases over to the docs fragment. Depends-On: ansible-collections#844 SUMMARY Migrate simplest cases over to the new docs fragment and add resource_tags as an alias to tags. ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME changelogs/fragments/1182-tagging.yml plugins/modules/aws_glue_job.py plugins/modules/aws_msk_cluster.py plugins/modules/aws_secret.py plugins/modules/aws_step_functions_state_machine.py plugins/modules/dynamodb_table.py plugins/modules/ec2_eip.py plugins/modules/ec2_transit_gateway_vpc_attachment.py plugins/modules/ec2_vpc_peer.py plugins/modules/elb_application_lb.py plugins/modules/elb_network_lb.py plugins/modules/iam_role.py plugins/modules/iam_user.py plugins/modules/networkfirewall.py plugins/modules/networkfirewall_policy.py plugins/modules/networkfirewall_rule_group.py plugins/modules/rds_cluster.py plugins/modules/rds_instance.py plugins/modules/rds_instance_snapshot.py plugins/modules/rds_option_group.py plugins/modules/rds_subnet_group.py plugins/modules/redshift.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@b11ffae
…nsible-collections#788) rds_cluster_snapshot - new module to handle RDS cluster snapshotting SUMMARY rds_cluster_snapshot - new module to handle RDS cluster snapshotting Requires rds_cluster to be merged first ansible-collections#687 Depends-On: ansible-collections#840 Requires: mattclay/aws-terminator#212 Requires also mattclay/aws-terminator#184 ISSUE TYPE New Module Pull Request COMPONENT NAME rds_cluster_snapshot Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Joseph Torcasso <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@5e7acbd
adjust booleans: use true/false Depends-On: ansible-collections#1423 SUMMARY ansible-community/community-topics#116 ISSUE TYPE Docs Pull Request Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@cb9716e
….py (ansible-collections#1417) Fix KeyError when Cluster Parameter Group is specified in rds_cluster.py SUMMARY Fix KeyError when comparing state. Fixes: ansible-collections#1409 ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_cluster.py Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@b3bc689
Uncomment rds_cluster snapshot tests SUMMARY Uncomment rds_cluster snapshot tests ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Jill R <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@f5b2da7
goneri
force-pushed
the
promote_rds_cluster
branch
from
978c28f
to
77ce0e1
Compare
|
regate |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 04s |
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
Sep 22, 2022
Migrate rds_cluster* modules and tests Depends-On: ansible-collections/amazon.aws#1027 Depends-On: #1478 Remove rds_cluster* modules and tests These modules have been migrated to amazon.aws Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: Mike Graves <mgraves@redhat.com> Reviewed-by: Bikouo Aubin <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Migrate rds_cluster* modules and tests Depends-On: ansible-collections#1027 Depends-On: ansible-collections#1478 Remove rds_cluster* modules and tests These modules have been migrated to amazon.aws Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: Mike Graves <mgraves@redhat.com> Reviewed-by: Bikouo Aubin <None> Reviewed-by: Mark Chappell <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Migrate rds_cluster* modules and tests Depends-On: ansible-collections#1027 Depends-On: ansible-collections#1478 Remove rds_cluster* modules and tests These modules have been migrated to amazon.aws Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: Mike Graves <mgraves@redhat.com> Reviewed-by: Bikouo Aubin <None> Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: ansible/zuul-config#443
Migrate rds_cluster* modules and tests