Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1071/ffd06e97 backport][stable-5] Handle ec2_vol.tags when the associated instance already exists #1423

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Mar 13, 2023

This is a backport of PR #1071 as merged into main (ffd06e9).

Signed-off-by: GomathiselviS gomathiselvi@gmail.com

SUMMARY

Fixes #1067
Fixes: #1421

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_vol.py

ADDITIONAL INFORMATION

Handle ec2_vol.tags when the associated instance already exists

Signed-off-by: GomathiselviS gomathiselvi@gmail.com
SUMMARY

Fixes #1067
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ec2_vol.py
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: GomathiselviS <None>
Reviewed-by: Mike Graves <mgraves@redhat.com>
Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
(cherry picked from commit ffd06e9)
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/67551a4530c744c587a379da331ef68c

✔️ ansible-galaxy-importer SUCCESS in 4m 41s
✔️ build-ansible-collection SUCCESS in 13m 07s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 11m 45s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 12m 14s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 11m 57s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 11m 58s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 44s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 00s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 37s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 9m 33s
✔️ cloud-tox-py3 SUCCESS in 4m 14s
✔️ ansible-test-changelog SUCCESS in 4m 18s
✔️ ansible-test-splitter SUCCESS in 5m 54s
integration-amazon.aws-1 RETRY_LIMIT in 1m 31s
Skipped 43 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Mar 13, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/db50804bc87344b2b751e30d00842b9d

✔️ ansible-galaxy-importer SUCCESS in 4m 18s
✔️ build-ansible-collection SUCCESS in 12m 17s
✔️ ansible-test-splitter SUCCESS in 4m 34s
✔️ integration-amazon.aws-1 SUCCESS in 15m 56s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 5b179e9 into stable-5 Mar 13, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-5/ffd06e9719a58d9d292bea90005e396a258f86d4/pr-1071 branch March 13, 2023 12:15
reparepo pushed a commit to reparepo/amazon.aws that referenced this pull request Mar 17, 2023
adjust booleans: use true/false

Depends-On: ansible-collections#1423
SUMMARY
ansible-community/community-topics#116
ISSUE TYPE

Docs Pull Request

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb9716e
reparepo pushed a commit to reparepo/amazon.aws that referenced this pull request Mar 17, 2023
adjust booleans: use true/false

Depends-On: ansible-collections#1423
SUMMARY
ansible-community/community-topics#116
ISSUE TYPE

Docs Pull Request

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb9716e
reparepo pushed a commit to reparepo/amazon.aws that referenced this pull request Mar 17, 2023
adjust booleans: use true/false

Depends-On: ansible-collections#1423
SUMMARY
ansible-community/community-topics#116
ISSUE TYPE

Docs Pull Request

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb9716e
reparepo pushed a commit to reparepo/amazon.aws that referenced this pull request Mar 17, 2023
adjust booleans: use true/false

Depends-On: ansible-collections#1423
SUMMARY
ansible-community/community-topics#116
ISSUE TYPE

Docs Pull Request

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb9716e
reparepo pushed a commit to reparepo/amazon.aws that referenced this pull request Mar 17, 2023
adjust booleans: use true/false

Depends-On: ansible-collections#1423
SUMMARY
ansible-community/community-topics#116
ISSUE TYPE

Docs Pull Request

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb9716e
reparepo pushed a commit to reparepo/amazon.aws that referenced this pull request Mar 17, 2023
adjust booleans: use true/false

Depends-On: ansible-collections#1423
SUMMARY
ansible-community/community-topics#116
ISSUE TYPE

Docs Pull Request

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb9716e
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
adjust booleans: use true/false

Depends-On: ansible-collections#1423
SUMMARY
ansible-community/community-topics#116
ISSUE TYPE


Docs Pull Request

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
adjust booleans: use true/false

Depends-On: ansible-collections#1423
SUMMARY
ansible-community/community-topics#116
ISSUE TYPE


Docs Pull Request

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Botocore test requirement cleanup

SUMMARY
When updating the minimum botocore/boto3 for the collection, I missed cleaning up some of integration tests which no longer need a newer version than the collection supports
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
tests/integration/targets/autoscaling_launch_config
tests/integration/targets/ec2_launch_template
tests/integration/targets/wafv2
tests/integration/targets/wafv2_web_acl
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
adjust booleans: use true/false

Depends-On: ansible-collections#1423
SUMMARY
ansible-community/community-topics#116
ISSUE TYPE


Docs Pull Request

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
adjust booleans: use true/false

Depends-On: ansible-collections#1423
SUMMARY
ansible-community/community-topics#116
ISSUE TYPE

Docs Pull Request

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb9716e
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
adjust booleans: use true/false

Depends-On: ansible-collections#1423
SUMMARY
ansible-community/community-topics#116
ISSUE TYPE

Docs Pull Request

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb9716e
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
adjust booleans: use true/false

Depends-On: ansible-collections#1423
SUMMARY
ansible-community/community-topics#116
ISSUE TYPE

Docs Pull Request

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb9716e
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 25, 2023
adjust booleans: use true/false

Depends-On: ansible-collections#1423
SUMMARY
ansible-community/community-topics#116
ISSUE TYPE

Docs Pull Request

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb9716e
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 26, 2023
adjust booleans: use true/false

Depends-On: ansible-collections#1423
SUMMARY
ansible-community/community-topics#116
ISSUE TYPE

Docs Pull Request

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb9716e
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 27, 2023
adjust booleans: use true/false

Depends-On: ansible-collections#1423
SUMMARY
ansible-community/community-topics#116
ISSUE TYPE

Docs Pull Request

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb9716e
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 19, 2024
adjust booleans: use true/false

Depends-On: ansible-collections#1423
SUMMARY
ansible-community/community-topics#116
ISSUE TYPE

Docs Pull Request

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@cb9716e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants