Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue #1421 by setting default #1422

Closed
wants to merge 2 commits into from
Closed

Fixing issue #1421 by setting default #1422

wants to merge 2 commits into from

Conversation

jamesv1994
Copy link

SUMMARY

We should set a default value like in line 454 as otherwise we receive exception mentioned in Issue #1421.

Fixes #1421

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME

ec2_vol

ADDITIONAL INFORMATION

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/27f8f72b94cd46e992049315347d6c00

✔️ ansible-galaxy-importer SUCCESS in 3m 55s
✔️ build-ansible-collection SUCCESS in 12m 26s
ansible-test-sanity-aws-ansible-python38 FAILURE in 10m 02s (non-voting)
ansible-test-sanity-aws-ansible-2.12-python38 FAILURE in 11m 00s
ansible-test-sanity-aws-ansible-2.13-python38 FAILURE in 9m 55s
ansible-test-sanity-aws-ansible-2.14 FAILURE in 9m 46s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 9m 05s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 9m 35s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 8m 59s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 8m 52s
✔️ cloud-tox-py3 SUCCESS in 8m 50s
ansible-test-changelog FAILURE in 4m 22s
✔️ ansible-test-splitter SUCCESS in 4m 39s
integration-amazon.aws-1 FAILURE in 13m 31s
Skipped 43 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/6cbb2e3a646e41528809ecb0f78c9dba

✔️ ansible-galaxy-importer SUCCESS in 4m 02s
✔️ build-ansible-collection SUCCESS in 12m 23s
ansible-test-sanity-aws-ansible-python38 FAILURE in 10m 10s (non-voting)
ansible-test-sanity-aws-ansible-2.12-python38 FAILURE in 8m 37s
ansible-test-sanity-aws-ansible-2.13-python38 FAILURE in 12m 30s
ansible-test-sanity-aws-ansible-2.14 FAILURE in 13m 38s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 8m 14s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 11m 07s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 9m 00s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 11m 27s
✔️ cloud-tox-py3 SUCCESS in 7m 12s
ansible-test-changelog FAILURE in 4m 22s
✔️ ansible-test-splitter SUCCESS in 5m 01s
integration-amazon.aws-1 FAILURE in 15m 26s
Skipped 43 jobs

@tremble
Copy link
Contributor

tremble commented Mar 13, 2023

Thanks for taking the time to open this PR.

The issue that this PR attempts to fix is actually fixed in the current "main" branch (which will become 6.0.0). However, we failed to backport it to the stable-5 branch.

The fix is #1071
The backport (which I just triggered) is #1423

@tremble tremble closed this Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modification of AWS EC2 Volume without Tags throws an exception
2 participants