[PR #715/1cd572b0 backport][stable-3] ec2_instance: add missing metadata_options parameters #721
Conversation
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
ec2_instance: add missing metadata_options parameters SUMMARY add missing metadata_options parameter http_put_response_hop_limit http_protocol_ipv6 instance_metadata_tags ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_instance Reviewed-by: Alina Buzachis <None> (cherry picked from commit 1cd572b)
ansibullbot
added
community_review
feature
|
recheck |
|
recheck |
|
recheck |
|
recheck |
|
recheck |
|
recheck |
1 similar comment
|
recheck |
|
recheck |
|
That looks distinctly like an "eventual-consistency" issue |
|
hm also number of network interfaces |
|
recheck |
|
recheck |
|
I've got a déjà-vu @tremble |
|
recheck |
|
regate |
|
recheck |
|
recheck |
|
recheck |
|
recheck |
|
recheck |
|
At this point I'm going close this PR. While it would be nice to backport, it's a feature rather than a bug fix and CI's really not liking it. There's been a number of minor tweaks across the board to improve stability with things like waiters and automatic retries, and they're probably playing into keeping ec2_instance just able to pass in main, but just failing in stable-3. ec2_instance is such a complex module that it's going to keep being right on the 1 hour border. Hopefully 4.0.0 is only a couple of weeks out, and hopefully there won't be a big delay between 3.4.0 and 4.0.0. |
1 similar comment
|
At this point I'm going close this PR. While it would be nice to backport, it's a feature rather than a bug fix and CI's really not liking it. There's been a number of minor tweaks across the board to improve stability with things like waiters and automatic retries, and they're probably playing into keeping ec2_instance just able to pass in main, but just failing in stable-3. ec2_instance is such a complex module that it's going to keep being right on the 1 hour border. Hopefully 4.0.0 is only a couple of weeks out, and hopefully there won't be a big delay between 3.4.0 and 4.0.0. |
ec2_instance: metadata_options version_added increased SUMMARY After CI troubles in the past, we've forget to backport this feature. incr from 3.2.0 to 3.3.0 #763 failed backport 3 PR for 3.2.0 release #721 initial implementation for 3.2.0 #715 therefore no changelog fragment is necessary. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
…ctions#852) ec2_instance: metadata_options version_added increased SUMMARY After CI troubles in the past, we've forget to backport this feature. incr from 3.2.0 to 3.3.0 ansible-collections#763 failed backport 3 PR for 3.2.0 release ansible-collections#721 initial implementation for 3.2.0 ansible-collections#715 therefore no changelog fragment is necessary. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION Reviewed-by: Jill R <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Chappell <None>
tremble
deleted the
patchback/backports/stable-3/1cd572b0ab50ab4d8a048f5420755dddf7403875/pr-715
branch
ansible-collections#721) Extended the wafv2_web_acl module with custom_response_bodies argument SUMMARY Extended the wafv2_web_acl module to also take the custom_response_bodies argument, improved docs and extended tests ISSUE TYPE Feature Pull Request COMPONENT NAME wafv2_web_acl ADDITIONAL INFORMATION Also touched docs of aws_waf_web_acl to make it easier to find the WAF v2 modules as I had trouble finding that at first. Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Stefan Horning <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None>
ansible-collections#721) Extended the wafv2_web_acl module with custom_response_bodies argument SUMMARY Extended the wafv2_web_acl module to also take the custom_response_bodies argument, improved docs and extended tests ISSUE TYPE Feature Pull Request COMPONENT NAME wafv2_web_acl ADDITIONAL INFORMATION Also touched docs of aws_waf_web_acl to make it easier to find the WAF v2 modules as I had trouble finding that at first. Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Stefan Horning <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None>
ansible-collections#721) Extended the wafv2_web_acl module with custom_response_bodies argument SUMMARY Extended the wafv2_web_acl module to also take the custom_response_bodies argument, improved docs and extended tests ISSUE TYPE Feature Pull Request COMPONENT NAME wafv2_web_acl ADDITIONAL INFORMATION Also touched docs of aws_waf_web_acl to make it easier to find the WAF v2 modules as I had trouble finding that at first. Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Stefan Horning <None> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None>
This is a backport of PR #715 as merged into main (1cd572b).
Depends-On: #734
SUMMARY
add missing metadata_options parameter
ISSUE TYPE
COMPONENT NAME
ec2_instance