Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_instance: metadata_options version_added increased #852

Conversation

markuman
Copy link
Member

@markuman markuman commented May 31, 2022

SUMMARY

After CI troubles in the past, we've forget to backport this feature.

therefore no changelog fragment is necessary.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_instance

ADDITIONAL INFORMATION

@github-actions
Copy link

github-actions bot commented May 31, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request module module needs_triage plugins plugin (any type) small_patch Hopefully easy to review labels May 31, 2022
@tremble
Copy link
Contributor

tremble commented May 31, 2022

I think we should wait for #721 to merge before updating this again. But I'm +1 assuming we can get #721 to merge.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 12s
✔️ build-ansible-collection SUCCESS in 5m 29s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 10s
✔️ ansible-test-sanity-aws-ansible-2.9-python38 SUCCESS in 12m 57s
✔️ ansible-test-sanity-aws-ansible-2.11-python38 SUCCESS in 10m 23s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 36s
✔️ ansible-test-splitter SUCCESS in 3m 05s
✔️ integration-amazon.aws-1 SUCCESS in 37m 56s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI isn't accepting the backport. With 4.0.0 so close let's cut our losses and call this a 4.0.0 feature.

plugins/modules/ec2_instance.py Outdated Show resolved Hide resolved
plugins/modules/ec2_instance.py Outdated Show resolved Hide resolved
plugins/modules/ec2_instance.py Outdated Show resolved Hide resolved
markuman and others added 3 commits June 22, 2022 15:18
Co-authored-by: Mark Chappell <mchappel@redhat.com>
Co-authored-by: Mark Chappell <mchappel@redhat.com>
Co-authored-by: Mark Chappell <mchappel@redhat.com>
@markuman markuman requested a review from tremble June 22, 2022 13:19
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Jun 22, 2022
@ansibullbot ansibullbot removed the small_patch Hopefully easy to review label Jun 22, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 22s
✔️ build-ansible-collection SUCCESS in 4m 51s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 24s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 36s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 29s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 21s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 21s
✔️ ansible-test-splitter SUCCESS in 2m 26s
✔️ integration-amazon.aws-1 SUCCESS in 33m 23s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
✔️ integration-community.aws-1 SUCCESS in 13m 19s
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 72580bc into ansible-collections:main Jun 22, 2022
jatorcasso pushed a commit to jatorcasso/amazon.aws that referenced this pull request Jun 27, 2022
…ctions#852)

ec2_instance: metadata_options version_added increased

SUMMARY
After CI troubles in the past, we've forget to backport this feature.

incr from 3.2.0 to 3.3.0 ansible-collections#763

failed backport 3 PR for 3.2.0 release ansible-collections#721


initial implementation for 3.2.0 ansible-collections#715

therefore no changelog fragment is necessary.
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_instance
ADDITIONAL INFORMATION

Reviewed-by: Jill R <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mark Chappell <None>
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 22, 2022
Cleanup unused imports

(ansible-collections#852 / ansible-collections#892) Let's try once more...
SUMMARY
My local tests are flagging that we've picked up some unused imports again.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
aws_glue_job
cloudfront_info
rds_option_group_info
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@017081c
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 23, 2022
Cleanup unused imports

(ansible-collections#852 / ansible-collections#892) Let's try once more...
SUMMARY
My local tests are flagging that we've picked up some unused imports again.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
aws_glue_job
cloudfront_info
rds_option_group_info
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@017081c
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
Cleanup unused imports

(ansible-collections#852 / ansible-collections#892) Let's try once more...
SUMMARY
My local tests are flagging that we've picked up some unused imports again.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
aws_glue_job
cloudfront_info
rds_option_group_info
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
Cleanup unused imports

(ansible-collections#852 / ansible-collections#892) Let's try once more...
SUMMARY
My local tests are flagging that we've picked up some unused imports again.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
aws_glue_job
cloudfront_info
rds_option_group_info
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
Cleanup unused imports

(ansible-collections#852 / ansible-collections#892) Let's try once more...
SUMMARY
My local tests are flagging that we've picked up some unused imports again.
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
aws_glue_job
cloudfront_info
rds_option_group_info
ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review feature This issue/PR relates to a feature request mergeit Merge the PR (SoftwareFactory) module module plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants