Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rds_instance - add valid choices for engine type #1034

Merged
merged 2 commits into from
Mar 30, 2022
Merged

rds_instance - add valid choices for engine type #1034

merged 2 commits into from
Mar 30, 2022

Conversation

jatorcasso
Copy link
Contributor

SUMMARY

Add valid choices for engine and update integration tests with new error msg

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

rds_instance

This was referenced Mar 30, 2022
Merged
Merged
@ansibullbot
Copy link

cc @jillr @markuman @s-hertel @tremble
click here for bot help

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Mar 30, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@jillr jillr added the mergeit Merge the PR (SoftwareFactory) label Mar 30, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit ddd30cf into ansible-collections:main Mar 30, 2022
@markuman markuman mentioned this pull request Mar 31, 2022
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Mar 31, 2022
@markuman
rds_instance - add valid choices for engine type (#1034) (#1040)
b81dccb 
backport-3: rds_instance - add valid choices for engine type (#1034)

backport rds_instance - add valid choices for engine type #1034
SUMMARY
Add valid choices for engine and update integration tests with new error msg
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
rds_instance
Reviewed-by: Jill R

Reviewed-by: Mark Woolley <mw@marknet15.com>
Reviewed-by: Alina Buzachis <None>
@renovate renovate bot mentioned this pull request Apr 6, 2022
Merged
1 task
@jatorcasso jatorcasso mentioned this pull request Apr 12, 2022
Merged
abikouo pushed a commit to abikouo/community.aws that referenced this pull request Oct 24, 2023
@jatorcasso @goneri
rds_instance - add valid choices for engine type (ansible-collections…
ea5258f 
…#1034)

rds_instance - add valid choices for engine type

SUMMARY
Add valid choices for engine and update integration tests with new error msg
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
rds_instance

Reviewed-by: Jill R <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections@ddd30cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jillr jillr jillr approved these changes

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jatorcasso @ansibullbot @jillr