[PR #1002/c403552f backport][stable-3] rds_instance - fix check_mode and idempotence bugs and support adding/removing iam roles #1055
Conversation
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
…/removing iam roles (#1002) rds_instance - fix check_mode and idempotence bugs and support adding/removing iam roles SUMMARY Support the addition and deletion of iam roles to db instances Fixes #464 Fixes #1013 Integration tests to test both this and the amazon.aws module_util rds changes Depends-On ansible-collections/amazon.aws#714 ISSUE TYPE Feature Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION Wasn't sure the best way to go about deleting IAM roles - ended up using a purge_iam_roles param that defaults to False, which seems consistent with other modules I've looked at. Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None> Reviewed-by: Markus Bergholz <git@osuv.de> (cherry picked from commit c403552)
ansibullbot
added
community_review
feature
@jatorcasso does this depends on unreleased amazon.aws changes? |
yes, it depends on #1034 and ansible-collections/amazon.aws#714, which were not backported |
I guess we can only backport this PR, if it will also be backported in amazon.aws and released with 3.3.0. |
|
I'm not super familiar with how this will work. Can I manually backport the 2 PRs it depends on, then backport this? |
Assuming they're suitable for backporting, yes. You can also add |
|
@markuman already backported #1034 (ty!) so all that's left is backporting ansible-collections/amazon.aws#714 which is ansible-collections/amazon.aws#771 |
|
recheck |
|
recheck |
There was a problem hiding this comment.
I just like to block this backport until #1064 (comment) is clearified.
Otherwise we'll introduce a new feature in 3.2.1
|
regate |
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-3/c403552f8d8d2da6be0a1797d6ac85ab1cd7b22c/pr-1002
branch
Update bools documentation in ec2_instance SUMMARY See also ansible-collections#1041 ISSUE TYPE Docs Pull Request COMPONENT NAME ec2_instance ADDITIONAL INFORMATION Split from ansible-collections#978 to work around CI issues Reviewed-by: Alina Buzachis <None>
This is a backport of PR #1002 as merged into main (c403552).
SUMMARY
Depends-On ansible-collections/amazon.aws#714
ISSUE TYPE
COMPONENT NAME
rds_instance
ADDITIONAL INFORMATION
Wasn't sure the best way to go about deleting IAM roles - ended up using a
purge_iam_rolesparam that defaults toFalse, which seems consistent with other modules I've looked at.