Use lower case days in rds_instance's "preferred_maintenance_window" parameter docs #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@markuman I agree, tweaking the documentation feels like the wrong solution. |
ansibullbot
added
community_review
docs
module
|
@dnmvisser Thanks for taking the time to submit this PR. This feels like the wrong solution: case shouldn't matter, it's too easy to get wrong and Amazon doesn't care about the case. I've started on #516 (the integration tests are currently a little broken) and will fix the underlying issue rather than papering-over the issue by changing the docs. |
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
…ollections#310) elbv2 boto3 client - implement new api for ip address type Reviewed-by: https://github.com/apps/ansible-zuul
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The current docs explicitly list the days with capitals (
Mon, Tue) etc. This works, but AWS then stores this as lowercase, causing idempotency issues the next time the task is run as the string value is different.ISSUE TYPE
COMPONENT NAME
rds_instanceADDITIONAL INFORMATION
The integration test actually do use the all lowercase format:
https://github.com/ansible-collections/community.aws/blob/main/tests/integration/targets/rds_instance/tasks/test_modification.yml#L152
NOTE: it looks as if other modules have a similar documentation issue, but I didn't confirm this:
https://github.com/ansible-collections/community.aws/blob/main/plugins/modules/rds.py#L137
https://github.com/ansible-collections/community.aws/blob/main/plugins/modules/redshift.py#L103