rds_instance - fix idempotency when using non-lowercase for preferred_maintenance_window #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
|
note: tests fail without #515 |
markuman
requested changes
Apr 1, 2021
ansibullbot
added
needs_revision
tremble
commented
Apr 3, 2021
tremble
force-pushed
the
rds_instance/preferred_maintenance_window
branch
from
d7797de
to
6b89a47
Compare
tremble
force-pushed
the
rds_instance/preferred_maintenance_window
branch
from
6b89a47
to
713219b
Compare
|
Tests also need #531 for the full suite to run. |
tremble
commented
Apr 7, 2021
|
Thanks for the reviews @markuman @alinabuzachis |
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…_maintenance_window (ansible-collections#516) * rds_instance - preferred_maintenance_window - force day of week into lowercase * add integration test * changelog
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
Jul 19, 2021
…_maintenance_window (ansible-collections#516) * rds_instance - preferred_maintenance_window - force day of week into lowercase * add integration test * changelog
danielcotton
pushed a commit
to danielcotton/community.aws
that referenced
this pull request
Nov 23, 2021
…_maintenance_window (ansible-collections#516) * rds_instance - preferred_maintenance_window - force day of week into lowercase * add integration test * changelog
alinabuzachis
pushed a commit
to alinabuzachis/community.aws
that referenced
this pull request
May 25, 2022
ec2_ami: Add check_mode support to ec2_ami SUMMARY Add check_mode support to ec2_ami. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_ami Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/community.aws
that referenced
this pull request
Oct 24, 2023
…_maintenance_window (ansible-collections#516) * rds_instance - preferred_maintenance_window - force day of week into lowercase * add integration test * changelog This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections@8fbfead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Rather than relying on changing the docs (#310) force the day of the week into lowercase so that it matches what AWS returns.
ISSUE TYPE
COMPONENT NAME
rds_instance
ADDITIONAL INFORMATION