Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make deprecated keys_attr param ignored in aws_kms_info #838

Merged
merged 3 commits into from
Dec 20, 2021
Merged

Make deprecated keys_attr param ignored in aws_kms_info #838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce06fb1
Apply deprecated change update to ignore param
marknet15 Dec 17, 2021
2ed170c
add changelog fragment
marknet15 Dec 17, 2021
7c09810
update changelog
marknet15 Dec 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/838-ignore-deprecated-param-aws_kms_info.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
breaking_changes:
- aws_kms_info - Deprecated ``keys_attr`` field is now ignored (https://github.com/ansible-collections/community.aws/pull/838).
3 changes: 1 addition & 2 deletions plugins/modules/aws_kms_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,10 +470,9 @@ def main():
# We originally returned "keys"
if module.params['keys_attr']:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

    if module.params.get('keys_attr', None) is not None:

module.deprecate("Returning results in the 'keys' attribute conflicts with the builtin keys() method on "
"dicts and as such is deprecated. Please use the kms_keys attribute. This warning can be "
"dicts and as such is deprecated and is now ignored. Please use the kms_keys attribute. This warning can be "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"dicts and as such is deprecated.",

"silenced by setting keys_attr to False.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line

version='3.0.0', collection_name='community.aws')
ret_params.update(dict(keys=filtered_keys))
module.exit_json(**ret_params)


Expand Down