Make deprecated keys_attr param ignored in aws_kms_info #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuman
approved these changes
Dec 17, 2021
alinabuzachis
approved these changes
Dec 20, 2021
![ansible-zuul[bot]](https://avatars.githubusercontent.com/in/27800?s=60&v=4){kind=small}
tremble
reviewed
Jan 7, 2022
| @@ -470,10 +470,9 @@ def main(): | |||
| # We originally returned "keys" | |||
| if module.params['keys_attr']: | |||
There was a problem hiding this comment.
if module.params.get('keys_attr', None) is not None:
| @@ -470,10 +470,9 @@ def main(): | |||
| # We originally returned "keys" | |||
| if module.params['keys_attr']: | |||
| module.deprecate("Returning results in the 'keys' attribute conflicts with the builtin keys() method on " | |||
| "dicts and as such is deprecated. Please use the kms_keys attribute. This warning can be " | |||
| "dicts and as such is deprecated and is now ignored. Please use the kms_keys attribute. This warning can be " | |||
There was a problem hiding this comment.
"dicts and as such is deprecated.",
| @@ -470,10 +470,9 @@ def main(): | |||
| # We originally returned "keys" | |||
| if module.params['keys_attr']: | |||
| module.deprecate("Returning results in the 'keys' attribute conflicts with the builtin keys() method on " | |||
| "dicts and as such is deprecated. Please use the kms_keys attribute. This warning can be " | |||
| "dicts and as such is deprecated and is now ignored. Please use the kms_keys attribute. This warning can be " | |||
| "silenced by setting keys_attr to False.", | |||
ansible-zuul bot
pushed a commit
that referenced
this pull request
Jan 7, 2022
aws_kms_info: Correct deprecation of keys_attr SUMMARY fixup derecation of keys_attr. ISSUE TYPE Feature Pull Request COMPONENT NAME aws_kms_info ADDITIONAL INFORMATION #838 Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Jill R <None> Reviewed-by: None <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 30, 2022
aws_kms_info - remove deprecated keys_attr parameter SUMMARY remove deprecated keys_attr parameter ISSUE TYPE Feature Pull Request COMPONENT NAME aws_kms_info ADDITIONAL INFORMATION See also: #838 Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Make deprecated
keys_attrparam ignored inaws_kms_infoas planned for3.0.0ISSUE TYPE
COMPONENT NAME
aws_kms_info
ADDITIONAL INFORMATION