Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_kms_info: Correct deprecation of keys_attr #851

Merged
merged 2 commits into from
Jan 7, 2022
Merged

aws_kms_info: Correct deprecation of keys_attr #851

merged 2 commits into from
Jan 7, 2022

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Jan 7, 2022

SUMMARY

fixup derecation of keys_attr.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

aws_kms_info

ADDITIONAL INFORMATION

#838

@alinabuzachis
Copy link
Contributor

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@markuman
Copy link
Member

markuman commented Jan 7, 2022

recheck

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

@tremble @markuman @jillr
Apply suggestions from code review
48a90bb 
Co-authored-by: Markus Bergholz <git@osuv.de>
Co-authored-by: Jill R <4121322+jillr@users.noreply.github.com>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@markuman markuman added the gate label Jan 7, 2022
ansible-zuul[bot]
ansible-zuul bot approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ansible-zuul ansible-zuul bot merged commit b1ce9fb into ansible-collections:main Jan 7, 2022
@tremble tremble deleted the aws_kms_info/keys_attr branch July 7, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuman markuman markuman left review comments

@jillr jillr jillr approved these changes

@ansible-zuul Ansible Zuul ansible-zuul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tremble @alinabuzachis @markuman @jillr