nios_host_record module doesn't allow to remove an alias/cname

[pescobar]

SUMMARY

When updating a host object to remove an alias (CNAME) module nios_host_record doesn't detect the removed alias and doesn't update the host object. It only updates the host object when adding extra aliases.

ISSUE TYPE

• Bug Report

COMPONENT NAME

nios_host_record

ANSIBLE VERSION

ansible 2.9.9
  config file = /home/ansible/ansible/playbooks/playbook-scicore-domains/ansible.cfg
  configured module search path = ['/home/ansible/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /opt/venvs_ansible/ansible_2.9.9/lib/python3.6/site-packages/ansible
  executable location = /opt/venvs_ansible/ansible_2.9.9/bin/ansible
  python version = 3.6.8 (default, Nov 21 2019, 19:31:34) [GCC 8.3.1 20190507 (Red Hat 8.3.1-4)]

CONFIGURATION

ansible-config dump --only-changed
COLLECTIONS_PATHS(/home/ansible/ansible/playbooks/playbook-scicore-domains/ansible.cfg) = ['/home/ansible/ansible/playbooks/playbook-scicore-domains/collections']

OS / ENVIRONMENT

We are running ansible on centos8 with python 3.6.8
collection community.general version 1.2.0
wapi_version: "2.3.1"
infoblox-client==0.5.0

STEPS TO REPRODUCE

When executing this playbook the second task doesn't change. Doesn't update the host object

---

- name: testing cnames
  hosts: localhost
  gather_facts: false
  become: no

  tasks:

    - name: Add host object with two aliases
      community.general.nios_host_record:
        name: testing-cnames.scicore.unibas.ch
        ipv4addrs:
          - address: 10.10.20.20
        aliases:
          - testing-cnames1.scicore.unibas.ch
          - testing-cnames2.scicore.unibas.ch
        state: present
        view: Internal
        provider: "{{ vault_nios_provider }}"

    - name: I try to delete one alias. IT DOESN'T WORK
      community.general.nios_host_record:
        name: testing-cnames.scicore.unibas.ch
        ipv4addrs:
          - address: 10.10.20.20
        aliases:
          - testing-cnames1.scicore.unibas.ch
        state: present
        view: Internal
        provider: "{{ vault_nios_provider }}"

    - name: I add a new extra alias. Now the alias to be removed in previous task is actually removed
      community.general.nios_host_record:
        name: testing-cnames.scicore.unibas.ch
        ipv4addrs:
          - address: 10.10.20.20
        aliases:
          - testing-cnames1.scicore.unibas.ch
          - testing-cnames3.scicore.unibas.ch
        state: present
        view: Internal
        provider: "{{ vault_nios_provider }}"

EXPECTED RESULTS

host object is updated removing an alias

ACTUAL RESULTS

host object is not updated and no alias is removed

EXTRA INFO

Checking the code I think the problem can be in this block of code https://github.com/ansible-collections/community.general/blob/main/plugins/module_utils/net_tools/nios/api.py#L433-L469 because function issubset will return true when removing an element from the list of aliases and thus the host object is not updated.

[ansibullbot]

Files identified in the description:

• plugins/modules/net_tools/nios/nios_host_record.py

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

[ansibullbot]

cc @NilashishC @Qalthos @danielmellado @ganeshrn @justjais @nerzhul @privateip @sganesh-infoblox @trishnaguha
click here for bot help

[pescobar]

ping

[pescobar]

This issue is fixed in #1470 so I am closing it