fix so module nios_host_record can remove aliases
#1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
affects_2.10
bug
|
Thanks for fixing this! Could you please add a changelog fragment? Also, you might want to create a similar PR in https://github.com/infobloxopen/infoblox-ansible/ since they also contain these modules, and the modules in here will probably be replaced by links to these modules in the future. |
|
@felixfontein I have added the requested changelog fragment. Let me know if any change is needed. I have also sent the same PR to |
Co-authored-by: Felix Fontein <felix@fontein.de>
|
thanks. I have merged your suggestion and also added |
felixfontein
approved these changes
Dec 14, 2020
|
@pescobar thanks for fixing this! |
felixfontein
pushed a commit
that referenced
this pull request
Dec 15, 2020
* fix for #1335 * added changelog fragment * Update changelogs/fragments/nios_host_record-fix-aliases-removal.yml Co-authored-by: Felix Fontein <felix@fontein.de> * extend changelog to specify CNAMES Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 496be77) Co-authored-by: Pablo Escobar Lopez <pescobar001@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
fix so module
nios_host_recordcan remove aliasesISSUE TYPE
COMPONENT NAME
nios_host_record
ADDITIONAL INFORMATION
Fix for #1335
I couldn't find any other module in https://github.com/ansible-collections/community.general/tree/main/plugins/modules/net_tools/nios with another argument named
aliasesso this change should only affect modulenios_host_record