Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

k8s: handle fail_json API from inventory plugin #417

Closed
wants to merge 1 commit into from

Conversation

Akasurde
Copy link
Member

SUMMARY
  • inventory plugin does not have module object so fail_json
    will not work. Use AnsibleError instead of fail_json

Fixes: #57

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/fail_json.yml
plugins/module_utils/common.py

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

❗ No coverage uploaded for pull request base (stable-1.2@f5eb062). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             stable-1.2     #417   +/-   ##
=============================================
  Coverage              ?   36.13%           
=============================================
  Files                 ?        4           
  Lines                 ?      786           
  Branches              ?      155           
=============================================
  Hits                  ?      284           
  Misses                ?      453           
  Partials              ?       49           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5eb062...626d00e. Read the comment docs.

* inventory plugin does not have module object so fail_json
  will not work. Use AnsibleError instead of ``fail_json``

Fixes: ansible-collections#57

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@gravesm
Copy link
Member

gravesm commented Apr 14, 2021

I think this should be filed in kubernetes.core.

@Akasurde
Copy link
Member Author

superseded by ansible-collections/kubernetes.core#59

@Akasurde Akasurde closed this Apr 15, 2021
@Akasurde Akasurde deleted the i57 branch April 15, 2021 09:25
@github-actions
Copy link

github-actions bot commented Nov 4, 2021

This repository does not accept pull requests, see the README for details.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants