Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s: handle fail_json API from inventory plugin #59

Merged
merged 1 commit into from
Apr 19, 2021
Merged

k8s: handle fail_json API from inventory plugin #59

merged 1 commit into from
Apr 19, 2021

Conversation

Akasurde
Copy link
Member

SUMMARY
  • inventory plugin does not have module object so fail_json
    will not work. Use AnsibleError instead of fail_json

Fixes: #57

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/fail_json.yml
plugins/inventory/k8s.py
plugins/module_utils/common.py
plugins/module_utils/exceptions.py

@Akasurde Akasurde mentioned this pull request Apr 15, 2021
Closed
@codecov
Copy link

codecov bot commented Apr 15, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (stable-1.2@f5eb062). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             stable-1.2      #59   +/-   ##
=============================================
  Coverage              ?   36.13%           
=============================================
  Files                 ?        4           
  Lines                 ?      786           
  Branches              ?      155           
=============================================
  Hits                  ?      284           
  Misses                ?      453           
  Partials              ?       49

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5eb062...48b6016. Read the comment docs.

@Akasurde
Copy link
Member Author

recheck

@Akasurde Akasurde closed this Apr 15, 2021
@Akasurde Akasurde reopened this Apr 15, 2021
abikouo
abikouo approved these changes Apr 16, 2021
View reviewed changes
Copy link
Contributor

@abikouo abikouo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Akasurde Akasurde mentioned this pull request Apr 16, 2021
Closed
@Akasurde Akasurde force-pushed the i57 branch 3 times, most recently from 77775bf to 6cc0630 Compare April 16, 2021 11:16
@Akasurde
k8s: handle fail_json API from inventory plugin
48b6016 
* inventory plugin does not have module object so fail_json
  will not work. Use AnsibleError instead of ``fail_json``

Fixes: ansible-collections#57

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
gravesm
gravesm approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@gravesm gravesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to backport the community.kubernetes -> kubernetes.core changes to this branch, so for now it should be fine to remain as community.kubernetes. As soon as this gets merged I'll do that backport.

@Akasurde Akasurde merged commit 4846b38 into ansible-collections:stable-1.2 Apr 19, 2021
@Akasurde Akasurde deleted the i57 branch April 19, 2021 06:00
@JiffsMaverick
Copy link

Today is July. There were still no fixes in versions 1.x or 2.x. @gravesm could you backport these fixes to main branch?

@gravesm
Copy link
Member

gravesm commented Jul 8, 2021

@JiffsMaverick Are you seeing an error? If so, could you create a new issue with the collection version and steps to reproduce?

@JiffsMaverick
Copy link

@gravesm Sorry, I didn't check it carefully. I checked again. There is a fix in both 1.x and 2.x. BUT! The problem is that version 1.2.2 (or 1.3.0?) hasn't been released yet. And version 2.1.1 is not included in Ansible 3/4 yet. Ok, I'll wait for the new releases...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abikouo abikouo abikouo approved these changes

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@gravesm gravesm gravesm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Akasurde @JiffsMaverick @gravesm @alinabuzachis @abikouo