Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm_repository: Silence false no_log warning #423

Merged

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Mar 30, 2022

Depends-On: #424

SUMMARY

Apply no_log=True to pass_credentials to silence
false positive warning.

Fixes: #412

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

changelogs/fragments/412_pass_creds.yml
plugins/modules/helm_repository.py

Apply no_log=True to pass_credentials to silence
false positive warning.

Fixes: ansible-collections#412

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@softwarefactory-project-zuul
Copy link

Build failed.

@gravesm
Copy link
Member

gravesm commented Mar 30, 2022

recheck

@softwarefactory-project-zuul
Copy link

Build succeeded.

@softwarefactory-project-zuul
Copy link

Build failed (gate pipeline). For information on how to proceed, see
http://docs.openstack.org/infra/manual/developers.html#automated-testing

@Akasurde
Copy link
Member Author

regate

@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit d311ac7 into ansible-collections:main Mar 30, 2022
@Akasurde Akasurde deleted the i412 branch March 31, 2022 02:23
gravesm pushed a commit to gravesm/kubernetes.core that referenced this pull request Jun 8, 2022
helm_repository: Silence false no_log warning

Depends-On: ansible-collections#424
SUMMARY
Apply no_log=True to pass_credentials to silence
false positive warning.
Fixes: ansible-collections#412
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
changelogs/fragments/412_pass_creds.yml
plugins/modules/helm_repository.py

Reviewed-by: Mike Graves <mgraves@redhat.com>
(cherry picked from commit d311ac7)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jun 8, 2022
[backport/2.3] helm_repository: Silence false no_log warning (#423)

Depends-on: ansible/ansible-zuul-jobs#1563
helm_repository: Silence false no_log warning
Depends-On: #424
SUMMARY
Apply no_log=True to pass_credentials to silence
false positive warning.
Fixes: #412
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
changelogs/fragments/412_pass_creds.yml
plugins/modules/helm_repository.py
Reviewed-by: Mike Graves mgraves@redhat.com
(cherry picked from commit d311ac7)
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jan 17, 2025
SUMMARY
Apply no_log=True to pass_credentials to silence false positive warning.
Fixes similar issue to: #423
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
changelog/fragements/796-false-positive-helmull.yaml
plugins/modules/helm_pull.py

Reviewed-by: Yuriy Novostavskiy
Reviewed-by: Mike Graves <mgraves@redhat.com>
Reviewed-by: Irum Malik
patchback bot pushed a commit that referenced this pull request Jan 17, 2025
SUMMARY
Apply no_log=True to pass_credentials to silence false positive warning.
Fixes similar issue to: #423
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
changelog/fragements/796-false-positive-helmull.yaml
plugins/modules/helm_pull.py

Reviewed-by: Yuriy Novostavskiy
Reviewed-by: Mike Graves <mgraves@redhat.com>
Reviewed-by: Irum Malik
(cherry picked from commit ecc64ca)
patchback bot pushed a commit that referenced this pull request Jan 17, 2025
SUMMARY
Apply no_log=True to pass_credentials to silence false positive warning.
Fixes similar issue to: #423
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
changelog/fragements/796-false-positive-helmull.yaml
plugins/modules/helm_pull.py

Reviewed-by: Yuriy Novostavskiy
Reviewed-by: Mike Graves <mgraves@redhat.com>
Reviewed-by: Irum Malik
(cherry picked from commit ecc64ca)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jan 17, 2025
This is a backport of PR #796 as merged into main (ecc64ca).
SUMMARY
Apply no_log=True to pass_credentials to silence false positive warning.
Fixes similar issue to: #423
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
changelog/fragements/796-false-positive-helmull.yaml
plugins/modules/helm_pull.py
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jan 17, 2025
This is a backport of PR #796 as merged into main (ecc64ca).
SUMMARY
Apply no_log=True to pass_credentials to silence false positive warning.
Fixes similar issue to: #423
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
changelog/fragements/796-false-positive-helmull.yaml
plugins/modules/helm_pull.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[WARNING]: Module did not set no_log for pass_credentials
2 participants