Skip to content

Commit

Permalink
helm_repository: Silence false no_log warning (ansible-collections#423)
Browse files Browse the repository at this point in the history
helm_repository: Silence false no_log warning

Depends-On: ansible-collections#424
SUMMARY
Apply no_log=True to pass_credentials to silence
false positive warning.
Fixes: ansible-collections#412
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
changelogs/fragments/412_pass_creds.yml
plugins/modules/helm_repository.py

Reviewed-by: Mike Graves <mgraves@redhat.com>
  • Loading branch information
Akasurde authored Mar 30, 2022
1 parent 7c71436 commit d311ac7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions changelogs/fragments/412_pass_creds.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
---
minor_changes:
- helm_repository - mark `pass_credentials` as no_log=True to silence false warning (https://github.com/ansible-collections/kubernetes.core/issues/412).
2 changes: 1 addition & 1 deletion plugins/modules/helm_repository.py
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ def main():
repo_state=dict(
default="present", choices=["present", "absent"], aliases=["state"]
),
pass_credentials=dict(type="bool", default=False),
pass_credentials=dict(type="bool", default=False, no_log=True),
# Generic auth key
host=dict(type="str", fallback=(env_fallback, ["K8S_AUTH_HOST"])),
ca_cert=dict(
Expand Down

0 comments on commit d311ac7

Please sign in to comment.