[Molecule v25.1.0] Replace util.run_command with app.run_command #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hswong3i
added a commit
to alvistack/ansible-community-molecule-plugins
that referenced
this pull request
Jan 22, 2025
git clean -xdf
tar zcvf ../python-molecule-plugins_23.6.0.orig.tar.gz --exclude=.git .
debuild -uc -us
cp python-molecule-plugins.spec ../python-molecule-plugins_23.6.0-1.spec
cp ../python*-molecule-plugins*23.6.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-plugins-23.6.0
rm -rf ../python*-molecule-plugins*23.6.0*.*
See ansible-community#155
See ansible-community#237
See ansible-community#294
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
apatard
reviewed
Jan 22, 2025
hswong3i
force-pushed
the
molecule-25.1.0-run_command
branch
from
637f56e to
31e3440
Compare
hswong3i
added a commit
to alvistack/ansible-community-molecule-plugins
that referenced
this pull request
Jan 22, 2025
git clean -xdf
tar zcvf ../python-molecule-plugins_23.6.0.orig.tar.gz --exclude=.git .
debuild -uc -us
cp python-molecule-plugins.spec ../python-molecule-plugins_23.6.0-1.spec
cp ../python*-molecule-plugins*23.6.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-plugins-23.6.0
rm -rf ../python*-molecule-plugins*23.6.0*.*
See ansible-community#155
See ansible-community#237
See ansible-community#294
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i
force-pushed
the
molecule-25.1.0-run_command
branch
from
96c1cf8 to
1f72244
Compare
…n_command() From ansible/molecule#4359 `util.run_command()` should now replaced with `get_app(Path()).run_command()`. Fixes ansible/molecule#4372 Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
hswong3i
force-pushed
the
molecule-25.1.0-run_command
branch
from
0a91829 to
0487341
Compare
hswong3i
added a commit
to alvistack/ansible-community-molecule-plugins
that referenced
this pull request
Jan 22, 2025
git clean -xdf
tar zcvf ../python-molecule-plugins_23.6.0.orig.tar.gz --exclude=.git .
debuild -uc -us
cp python-molecule-plugins.spec ../python-molecule-plugins_23.6.0-1.spec
cp ../python*-molecule-plugins*23.6.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-plugins-23.6.0
rm -rf ../python*-molecule-plugins*23.6.0*.*
See ansible-community#155
See ansible-community#237
See ansible-community#294
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
7 tasks
7 tasks
apatard
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
The test suite seems fine on my test sandbox (my test setup is allowing to run vagrant tests too) and the github one is fine too. Thanks.
I would have preferred to not require latest molecule version as it's quite new but we've already did that in the past and 6.0.0 is old. So, I guess it's fine too
|
@apatard - Will there be a new release soon? |
I'm not sure I'll manage to do it today. Given how important this fix is, I'll try to make a release tomorrow. |
hswong3i
added a commit
to alvistack/ansible-community-molecule-plugins
that referenced
this pull request
Jan 23, 2025
git clean -xdf
tar zcvf ../python-molecule-plugins_23.6.0.orig.tar.gz --exclude=.git .
debuild -uc -us
cp python-molecule-plugins.spec ../python-molecule-plugins_23.6.0-1.spec
cp ../python*-molecule-plugins*23.6.0*.{gz,xz,spec,dsc} /osc/home\:alvistack/ansible-community-molecule-plugins-23.6.0
rm -rf ../python*-molecule-plugins*23.6.0*.*
See ansible-community#155
See ansible-community#237
See ansible-community#294
Signed-off-by: Wong Hoi Sing Edison <hswong3i@pantarei-design.com>
apatard
added a commit
to apatard/molecule-plugins
that referenced
this pull request
Jan 23, 2025
When ansible-community#294, I didn't notice that the python version was not inside quotes, leading to python version being parsed as 3.1 and not 3.10. Breaking the release workflow. Add missing quotes. Signed-off-by: Arnaud Patard <arnaud.patard@collabora.com>
|
Update: |
apatard
added a commit
that referenced
this pull request
Jan 23, 2025
When #294, I didn't notice that the python version was not inside quotes, leading to python version being parsed as 3.1 and not 3.10. Breaking the release workflow. Add missing quotes. Signed-off-by: Arnaud Patard <arnaud.patard@collabora.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From ansible/molecule#4359
util.run_commandshould now replaced withapp.run_command.Fixes ansible/molecule#4372