Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/release.yml: Fix release #296

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

apatard
Copy link
Member

@apatard apatard commented Jan 23, 2025

When #294, I didn't notice that the python version was not inside quotes, leading to python version being parsed as 3.1 and not 3.10. Breaking the release workflow.
Add missing quotes.

When ansible-community#294, I didn't notice that the python version was not inside
quotes, leading to python version being parsed as 3.1 and not 3.10.
Breaking the release workflow.
Add missing quotes.

Signed-off-by: Arnaud Patard <arnaud.patard@collabora.com>
@apatard apatard added the bug Something isn't working label Jan 23, 2025
@apatard apatard requested review from ssbarnea and oraNod January 23, 2025 10:05
@apatard apatard enabled auto-merge (rebase) January 23, 2025 10:13
Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @apatard

@apatard apatard merged commit 980db38 into ansible-community:main Jan 23, 2025
10 of 11 checks passed
@apatard
Copy link
Member Author

apatard commented Jan 23, 2025

@oraNod I guess I've to create a minor release to run again the release workflow and publish the release to pypi ?

@oraNod
Copy link
Contributor

oraNod commented Jan 23, 2025

@apatard Hey, I think it might be better to delete the failed release and try again. The steps in this post seem good: https://vishnugopal.com/2020/05/02/recreating-a-failed-github-release-with-the-same-tag/

Hope that helps and give me a shout if you need anything. Cheers.

@apatard
Copy link
Member Author

apatard commented Jan 23, 2025

@oraNod It seems to have worked. Thanks a lot !

@oraNod oraNod mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants