Cli textfsm fixes #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g of cisco ios Signed-off-by: jwoogee <jswoods1@gmail.com>
Signed-off-by: jwoogee <jswoods1@gmail.com>
|
Build succeeded.
|
|
Build failed.
|
|
Build failed.
|
Signed-off-by: z003gn3 <jonathon.woods@target.com>
jwoogee
force-pushed
the
cli_textfsm_fixes
branch
from
7fbec25 to
9a4f1c8
Compare
|
Build succeeded.
|
trishnaguha
approved these changes
Dec 3, 2018
NilashishC
pushed a commit
to NilashishC/cisco_ios
that referenced
this pull request
Jan 7, 2019
* pass name argument for textfsm, and fix blank lines applying to config of cisco ios Signed-off-by: jwoogee <jswoods1@gmail.com> * fixed duplicate and Signed-off-by: jwoogee <jswoods1@gmail.com> * changed vars to 'name' to match text_fsm naming Signed-off-by: z003gn3 <jonathon.woods@target.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there's no way to get textfsm_parser to populate ansible_facts with this role. We need to pass name to the parser to set the dictionary key facts will be added to. I have a separate pull request for ansible-network.network-engine to take in this argument to the cli module.
I also fixed issue where cli would fail when terminal.yaml would pass a blank line showing up from jinja render, now terminal.yaml just skips those blank lines.
Signed-off-by: jwoogee jswoods1@gmail.com