adding name option for textfsm to create facts to key

[jwoogee]

Adding name option for textfsm so it has a key to set ansible_facts to. This is related to changes to ansible-network.cisco_ios, found here, ansible-network/cisco_ios#51

Signed-off-by: jwoogee jswoods1@gmail.com

[softwarefactory-project-zuul]

Build succeeded.

• tox-linters : SUCCESS in 3m 54s
• ansible-network-tox-py27 : SUCCESS in 7m 40s
• ansible-network-tox-py36 : SUCCESS in 4m 43s
• ansible-test-sanity : FAILURE in 4m 15s (non-voting)
• dco-license : SUCCESS in 27s

[trishnaguha]

Instead of key_name can you please keep the term same as name.
Also please add documentation for the new option here

network-engine/action_plugins/cli.py

Lines 14 to 47 in 0d2cff2

	DOCUMENTATION = """
	---
	module: cli
	author: Ansible Network Team
	short_description: Runs the specific command and returns the output
	description:
	- The command specified in C(command) will be executed on the remote
	device and its output will be returned to the module. This module
	requires that the device is supported using the C(network_cli)
	connection plugin and has a valid C(cliconf) plugin to work correctly.
	version_added: "2.5"
	options:
	command:
	description:
	- The command to be executed on the remote node. The value for this
	argument will be passed unchanged to the network device and the
	output returned.
	required: yes
	default: null
	parser:
	description:
	- The parser file to pass the output from the command through to
	generate Ansible facts. If this argument is specified, the output
	from the command will be parsed based on the rules in the
	specified parser.
	default: null
	engine:
	description:
	- Defines the engine to use when parsing the output. This argument
	accepts one of two valid values, C(command_parser) or C(textfsm_parser).
	default: command_parser
	choices:
	- command_parser
	- textfsm_parser

[jwoogee]

I'm looking into this more, should we call it register to match what we typically do when assigning keys in ansible? Let me know if you have a preference and I'll update it.

[trishnaguha]

@jwoogee textfsm_parser module uses the parameter name to return ansible_facts https://github.com/ansible-network/network-engine/blob/devel/library/textfsm_parser.py#L46.
We don't want to call it register as it might create confusion in case there is a necessity of using register from ansible in the same task.

[jwoogee]

Thank you @trishnaguha , I've changed the term to 'name'.
Would you be able to help with PR ansible-network/cisco_ios#51 or do you know who I can assign as reviewer on that one?

[trishnaguha]

Yes I can definitely help with that one.

[softwarefactory-project-zuul]

Build succeeded.

• tox-linters : SUCCESS in 4m 18s
• ansible-network-tox-py27 : SUCCESS in 4m 15s
• ansible-network-tox-py36 : SUCCESS in 4m 15s
• ansible-test-sanity : FAILURE in 4m 12s (non-voting)
• dco-license : SUCCESS in 24s