Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runner artifact cleanup does not always run #497

Open
cidrblock opened this issue Jun 24, 2021 · 3 comments
Open

runner artifact cleanup does not always run #497

cidrblock opened this issue Jun 24, 2021 · 3 comments
Assignees
Labels
affects_post_2.0 Needed after the 2.0 release bug Researched, reproducible, committed to fix

Comments

@cidrblock
Copy link
Collaborator

cidrblock commented Jun 24, 2021

found while working on #496

@cidrblock cidrblock added affects_post_2.0 Needed after the 2.0 release bug Researched, reproducible, committed to fix labels Jun 24, 2021
@ganeshrn ganeshrn added the new New issues and PRs to triaged label Aug 23, 2021
@ganeshrn ganeshrn removed the new New issues and PRs to triaged label Oct 18, 2021
@cidrblock
Copy link
Collaborator Author

We could store the directory in args.internals https://github.com/ansible/ansible-navigator/blob/main/src/ansible_navigator/configuration_subsystem/navigator_configuration.py#L150 and do the clean up in cli.py at the exit

@ganeshrn
Copy link
Member

Approach-1
the artifact_dir passed by ansible-runner can be set in args to the clean up in cli.py

Approach-2

Handle in signal handler https://docs.python.org/3/library/signal.html

eamigo added a commit to eamigo/ansible-navigator that referenced this issue Feb 12, 2023
eamigo added a commit to eamigo/ansible-navigator that referenced this issue Feb 12, 2023
eamigo added a commit to eamigo/ansible-navigator that referenced this issue Feb 12, 2023
@eamigo
Copy link
Contributor

eamigo commented Apr 4, 2023

@cidrblock I think this issue may have been accidentally closed early. You mentioned here that you wanted this to remain open. #1438 (comment)

@cidrblock cidrblock reopened this Jun 22, 2023
@shatakshiiii shatakshiiii self-assigned this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects_post_2.0 Needed after the 2.0 release bug Researched, reproducible, committed to fix
Projects
Status: No status
Development

No branches or pull requests

4 participants