Runner artifact cleanup #1438
Merged
Runner artifact cleanup #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shatakshiiii
requested review from
cidrblock,
a team,
ssbarnea,
audgirka and
shatakshiiii
|
Approving this, although I'm going to leave #497 open because we really need to not be using TY for this BTW!, sorry it took a bit to get reviewed |
cidrblock
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The artifact_dir was only deleted if --rac was set by the user.
This will now delete the entire temporary private_data_dir instead of just the artifacts_dir from the last run if the private_data_dir is a generated temp directory.
Related: #497
Closes: #520