-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catalog roles within a collection #1059
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relrod
reviewed
Mar 7, 2022
cidrblock
force-pushed
the
catalog_roles
branch
2 times, most recently
from
March 9, 2022 17:05
f6f1194
to
7a9a29e
Compare
cidrblock
force-pushed
the
catalog_roles
branch
from
March 10, 2022 16:27
89dde6d
to
ea6d165
Compare
cidrblock
changed the title
[WIP] Catalog roles within a collection
Catalog roles within a collection
Mar 10, 2022
for more information, see https://pre-commit.ci
cidrblock
requested review from
a team,
relrod,
ssbarnea,
webknjaz,
ganeshrn,
alisonlhart and
thedoubl3j
March 10, 2022 16:34
ganeshrn
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #231
catalog_collections.py
to also catalog roles within a collection.collections.py
because it's not just plugins anymore