-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EE volume mount issue #1061
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 8, 2022
relrod
reviewed
Mar 8, 2022
src/ansible_navigator/configuration_subsystem/navigator_post_processor.py
Outdated
Show resolved
Hide resolved
src/ansible_navigator/configuration_subsystem/navigator_post_processor.py
Outdated
Show resolved
Hide resolved
src/ansible_navigator/configuration_subsystem/navigator_post_processor.py
Outdated
Show resolved
Hide resolved
src/ansible_navigator/configuration_subsystem/navigator_post_processor.py
Outdated
Show resolved
Hide resolved
relrod
reviewed
Mar 9, 2022
src/ansible_navigator/configuration_subsystem/navigator_post_processor.py
Show resolved
Hide resolved
src/ansible_navigator/configuration_subsystem/navigator_post_processor.py
Outdated
Show resolved
Hide resolved
src/ansible_navigator/configuration_subsystem/navigator_post_processor.py
Outdated
Show resolved
Hide resolved
src/ansible_navigator/configuration_subsystem/navigator_post_processor.py
Show resolved
Hide resolved
src/ansible_navigator/configuration_subsystem/navigator_post_processor.py
Outdated
Show resolved
Hide resolved
src/ansible_navigator/configuration_subsystem/navigator_post_processor.py
Show resolved
Hide resolved
src/ansible_navigator/configuration_subsystem/navigator_post_processor.py
Show resolved
Hide resolved
src/ansible_navigator/configuration_subsystem/navigator_post_processor.py
Show resolved
Hide resolved
src/ansible_navigator/configuration_subsystem/navigator_post_processor.py
Show resolved
Hide resolved
src/ansible_navigator/configuration_subsystem/navigator_post_processor.py
Show resolved
Hide resolved
relrod
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #1059 I noticed this:
The issue was a EEV entry with source of C.PREVIOUS_CLI was being processed as if it was a settings file entry, it can be seen:
Overview:
from_string
andfrom_dictionary
method toVolumeMount
execution_environment_volume_mounts
to build a list ofVolumeMount
/tmp
instead of fake directories to avoid the early exit,
in the EE volmountsSome more tests coming as well.