Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EE volume mount issue #1061

Merged
merged 24 commits into from
Mar 10, 2022
Merged

Fix EE volume mount issue #1061

merged 24 commits into from
Mar 10, 2022

Conversation

cidrblock
Copy link
Collaborator

@cidrblock cidrblock commented Mar 7, 2022

When working on #1059 I noticed this:

The issue was a EEV entry with source of C.PREVIOUS_CLI was being processed as if it was a settings file entry, it can be seen:

220307235030.086 WARNING 'ansible_navigator.actions.config._update_args' The following execution-environment.volume-mounts entry could not be parsed: /home/collections:/tmp/collections_to_volmount:z
220307235030.086 INFO 'ansible_navigator.actions.config._update_args' The value of execution-environment.volume-mounts should be list of dictionaries and valid keys are 'src', 'dest' and 'label'.

Overview:

  • Add a from_string and from_dictionary method to VolumeMount
  • Refactor execution_environment_volume_mounts to build a list of VolumeMount
  • Check the source of all volume mounts and exit early if one is not real
  • Update tests to use /tmp instead of fake directories to avoid the early exit
  • Added per SettingsEntry env var split character to account for a , in the EE volmounts

Some more tests coming as well.

@cidrblock cidrblock requested a review from a team March 7, 2022 23:47
@cidrblock cidrblock self-assigned this Mar 7, 2022
@cidrblock cidrblock marked this pull request as draft March 8, 2022 00:10
@cidrblock cidrblock changed the title Fix EE volume mount issue [WIP] Fix EE volume mount issue Mar 8, 2022
@cidrblock cidrblock requested a review from relrod March 8, 2022 18:06
@cidrblock cidrblock marked this pull request as ready for review March 8, 2022 18:06
@cidrblock cidrblock changed the title [WIP] Fix EE volume mount issue Fix EE volume mount issue Mar 8, 2022
@cidrblock cidrblock merged commit 8235ecd into ansible:main Mar 10, 2022
@cidrblock cidrblock added the major PR: Requires a major release label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major PR: Requires a major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants