Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exec subcommand #624

Merged
merged 59 commits into from
Dec 14, 2021
Merged

exec subcommand #624

merged 59 commits into from
Dec 14, 2021

Conversation

cidrblock
Copy link
Collaborator

@cidrblock cidrblock commented Nov 19, 2021 •
edited
Loading

Demo

  • Add exec action
  • Add exec subcommand
  • Add exec_command and exec_shell settings entries
  • Add support for actions that may be stdout only
  • Update test data as needed
  • Update tests to shlex split for first use of space delimited parameter
  • add flake8 file to set docstring format to sphinx
  • one black fix in utils, ergh

Fixes: #526

@cidrblock
Copy link
Collaborator Author

recheck

3 similar comments
@cidrblock
Copy link
Collaborator Author

recheck

@cidrblock
Copy link
Collaborator Author

recheck

@cidrblock
Copy link
Collaborator Author

recheck

@cidrblock cidrblock mentioned this pull request Nov 29, 2021
Closed
@cidrblock
Copy link
Collaborator Author

recheck

2 similar comments
@cidrblock
Copy link
Collaborator Author

recheck

@cidrblock
Copy link
Collaborator Author

recheck

@cidrblock cidrblock changed the title Initial work for exec subcommand exec subcommand Nov 30, 2021
@cidrblock cidrblock marked this pull request as ready for review November 30, 2021 21:30
@cidrblock cidrblock requested review from a team, ssbarnea, webknjaz, ganeshrn, thedoubl3j and alisonlhart and removed request for ssbarnea, webknjaz and ganeshrn November 30, 2021 21:30
@cidrblock
Copy link
Collaborator Author

recheck

relrod
relrod reviewed Nov 30, 2021
View reviewed changes
Copy link
Member

@relrod relrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments.

src/ansible_navigator/app.py Outdated Show resolved Hide resolved
src/ansible_navigator/actions/_actions.py Outdated Show resolved Hide resolved
src/ansible_navigator/actions/exec.py Outdated Show resolved Hide resolved
src/ansible_navigator/configuration_subsystem/navigator_configuration.py Outdated Show resolved Hide resolved
src/ansible_navigator/configuration_subsystem/navigator_configuration.py Show resolved Hide resolved
src/ansible_navigator/configuration_subsystem/navigator_configuration.py Show resolved Hide resolved
src/ansible_navigator/configuration_subsystem/navigator_configuration.py Outdated Show resolved Hide resolved
@cidrblock cidrblock requested review from a team, ssbarnea, webknjaz and ganeshrn December 1, 2021 16:07
@cidrblock cidrblock self-assigned this Dec 2, 2021
@cidrblock
Copy link
Collaborator Author

Recheck

@cidrblock
Copy link
Collaborator Author

recheck

1 similar comment
@cidrblock
Copy link
Collaborator Author

recheck

@cidrblock @webknjaz
Update src/ansible_navigator/actions/exec.py
0ebf309 
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
@cidrblock cidrblock mentioned this pull request Dec 14, 2021
Merged
@cidrblock cidrblock mentioned this pull request Dec 14, 2021
Merged
@cidrblock @webknjaz
Update tests/integration/actions/exec/base.py
74ff5de 
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
@cidrblock cidrblock added the gate label Dec 14, 2021
ansible-zuul[bot]
ansible-zuul bot approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@ansible-zuul ansible-zuul bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ansible-zuul bot pushed a commit that referenced this pull request Dec 14, 2021
@cidrblock
Allow implicit string concatenation (#740)
122b96a 
[lint-vetting] Allow implicit string concatenation

This is related to a linter that is being vetted, not enforced.
https://wemake-python-stylegui.de/en/latest/pages/usage/violations/consistency.html#wemake_python_styleguide.violations.consistency.ImplicitStringConcatenationViolation
This was discussed briefly here:
#624 (comment)

Reviewed-by: Sviatoslav Sydorenko <webknjaz+github/profile@redhat.com>
Reviewed-by: Sorin Sbarnea <sorin.sbarnea@gmail.com>
Reviewed-by: None <None>
@ansible-zuul ansible-zuul bot merged commit f73f4a0 into ansible:main Dec 14, 2021
ansible-zuul bot pushed a commit that referenced this pull request Dec 16, 2021
@cidrblock
f8 (#741)
8fa494e 
[lint-vetting] Allow `hasattr` and others

This is for a linter that is being vetted not enforced
https://wemake-python-stylegui.de/en/0.9.1/pages/violations/best_practices.html?highlight=FUNCTIONS_BLACKLIST#wemake_python_styleguide.violations.best_practices.WrongFunctionCallViolation
forbids:
FUNCTIONS_BLACKLIST = frozenset({'__import__', 'compile', 'copyright', 'credits', 'delattr', 'dir', 'eval', 'exec', 'exit', 'globals', 'hasattr', 'help', 'input', 'locals', 'quit', 'staticmethod', 'vars'})

Some discussion about this happened here:
#624 (comment)

Reviewed-by: Sviatoslav Sydorenko <webknjaz+github/profile@redhat.com>
Reviewed-by: Sorin Sbarnea <sorin.sbarnea@gmail.com>
Reviewed-by: Rick Elrod <rick@elrod.me>
Reviewed-by: None <None>
cidrblock added a commit to cidrblock/ansible-navigator that referenced this pull request Jan 11, 2022
@cidrblock
Allow implicit string concatenation (ansible#740)
7b7bbd5 
[lint-vetting] Allow implicit string concatenation

This is related to a linter that is being vetted, not enforced.
https://wemake-python-stylegui.de/en/latest/pages/usage/violations/consistency.html#wemake_python_styleguide.violations.consistency.ImplicitStringConcatenationViolation
This was discussed briefly here:
ansible#624 (comment)

Reviewed-by: Sviatoslav Sydorenko <webknjaz+github/profile@redhat.com>
Reviewed-by: Sorin Sbarnea <sorin.sbarnea@gmail.com>
Reviewed-by: None <None>
cidrblock added a commit to cidrblock/ansible-navigator that referenced this pull request Jan 11, 2022
@cidrblock
exec subcommand (ansible#624)
1134362 
`exec` subcommand

Demo

Add exec action
Add exec subcommand
Add exec_command and exec_shell settings entries
Add support for actions that may be stdout only
Update test data as needed
Update tests to shlex split for first use of space delimited parameter
add flake8 file to set docstring format to sphinx
one black fix in utils, ergh

Fixes: ansible#526

Reviewed-by: Rick Elrod <rick@elrod.me>
Reviewed-by: Bradley A. Thornton <bthornto@redhat.com>
Reviewed-by: Alison Hart <contact@alisonlhart.com>
Reviewed-by: Sviatoslav Sydorenko <webknjaz+github/profile@redhat.com>
Reviewed-by: Jake Jackson  <jljacks93@gmail.com>
Reviewed-by: None <None>
cidrblock added a commit to cidrblock/ansible-navigator that referenced this pull request Jan 11, 2022
@cidrblock
f8 (ansible#741)
df924b9 
[lint-vetting] Allow `hasattr` and others

This is for a linter that is being vetted not enforced
https://wemake-python-stylegui.de/en/0.9.1/pages/violations/best_practices.html?highlight=FUNCTIONS_BLACKLIST#wemake_python_styleguide.violations.best_practices.WrongFunctionCallViolation
forbids:
FUNCTIONS_BLACKLIST = frozenset({'__import__', 'compile', 'copyright', 'credits', 'delattr', 'dir', 'eval', 'exec', 'exit', 'globals', 'hasattr', 'help', 'input', 'locals', 'quit', 'staticmethod', 'vars'})

Some discussion about this happened here:
ansible#624 (comment)

Reviewed-by: Sviatoslav Sydorenko <webknjaz+github/profile@redhat.com>
Reviewed-by: Sorin Sbarnea <sorin.sbarnea@gmail.com>
Reviewed-by: Rick Elrod <rick@elrod.me>
Reviewed-by: None <None>
@cidrblock cidrblock added the enhancement New feature or request label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@relrod relrod relrod left review comments

@webknjaz webknjaz webknjaz left review comments

@thedoubl3j thedoubl3j thedoubl3j left review comments

@alisonlhart alisonlhart alisonlhart left review comments

@ansible-zuul ansible-zuul[bot] ansible-zuul[bot] approved these changes

@ssbarnea ssbarnea Awaiting requested review from ssbarnea ssbarnea is a code owner automatically assigned from ansible/devtools

@ganeshrn ganeshrn Awaiting requested review from ganeshrn ganeshrn is a code owner automatically assigned from ansible/devtools

Assignees

@cidrblock cidrblock

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow for interactive development within the container
5 participants
@cidrblock @relrod @webknjaz @thedoubl3j @alisonlhart