Bump AWS Integration tests to later Python #1816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 10m 38s |
|
It now stops a bit later, complaining that there are no selinux bindings for Python 3.11: 🙄 |
|
Using 3.10 will get you past the selinux issues, but then fail to install pyyaml because of aws/aws-cli#8036, which I assume would also be a problem with 3.11. |
|
#1819 should fix the selinux problem. |
|
There's also zuul.d/amazon-aws-periodical-jobs.yaml which also needs to be updated I guess (#1817). (See https://github.com/ansible/ansible-zuul-jobs/pull/1817/files) |
|
@tremble What's the Python version we want to use: 3.10 or 3.11? There's also this PR https://github.com/ansible/ansible-zuul-jobs/pull/1818/files that updates the zuul.d/amazon-aws-periodical-jobs.yaml to 3.10. |
We now run the compile and unit tests against all supported versions, IMO we can use either. I'd lean towards 3.11 to increase the chance that we're away from Zuul by the time this hits again |
|
Strongly prefer 3.11 for the reason @tremble stated. |
alinabuzachis
approved these changes
Aug 22, 2023
|
Build succeeded (gate pipeline). ✔️ ansible-tox-linters SUCCESS in 10m 29s |
softwarefactory-project-zuul
bot
merged commit f16d066
into
ansible:master
2 checks passed
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
Aug 24, 2023
CI: Force PyYAML version that can be installed SUMMARY Currently integration tests with ansible/ansible-zuul-jobs#1816 still fail when installing some requirements: 2023-08-22 05:53:46.350742 | TASK [ansible-test : Install python requirements] [...] 2023-08-22 05:53:53.860850 | controller | Collecting PyYAML<5.5,>=3.10 (from awscli->-r /home/zuul-worker/.ansible/collections/ansible_collections/community/aws/test-requirements.txt (line 19)) 2023-08-22 05:53:53.866271 | controller | Downloading PyYAML-5.4.1.tar.gz (175 kB) 2023-08-22 05:53:53.878160 | controller | �������������������������������������� 175.1/175.1 kB 19.0 MB/s eta 0:00:00 2023-08-22 05:53:54.065094 | controller | Installing build dependencies: started 2023-08-22 05:53:58.372457 | controller | Installing build dependencies: finished with status 'done' 2023-08-22 05:53:58.373282 | controller | Getting requirements to build wheel: started 2023-08-22 05:53:58.680407 | controller | Getting requirements to build wheel: finished with status 'error' 2023-08-22 05:53:58.689654 | controller | error: subprocess-exited-with-error (https://b3e35e76f7fc3e0cf6b5-d430d94f79a1de67219002b64dcf7484.ssl.cf1.rackcdn.com/1904/63f02a9c37ef75f9dcf25159fb4033d6edf146ee/check/integration-community.aws-1/b2f8016/job-output.txt) Tries to work around this problem by pinning the PyYAML version to 5.3.1 (see also yaml/pyyaml#736). ISSUE TYPE Test Pull Request COMPONENT NAME integration tests Reviewed-by: Alina Buzachis Reviewed-by: Mark Chappell Reviewed-by: Felix Fontein <felix@fontein.de> Reviewed-by: Markus Bergholz <git@osuv.de>
patchback bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
Aug 24, 2023
CI: Force PyYAML version that can be installed SUMMARY Currently integration tests with ansible/ansible-zuul-jobs#1816 still fail when installing some requirements: 2023-08-22 05:53:46.350742 | TASK [ansible-test : Install python requirements] [...] 2023-08-22 05:53:53.860850 | controller | Collecting PyYAML<5.5,>=3.10 (from awscli->-r /home/zuul-worker/.ansible/collections/ansible_collections/community/aws/test-requirements.txt (line 19)) 2023-08-22 05:53:53.866271 | controller | Downloading PyYAML-5.4.1.tar.gz (175 kB) 2023-08-22 05:53:53.878160 | controller | �������������������������������������� 175.1/175.1 kB 19.0 MB/s eta 0:00:00 2023-08-22 05:53:54.065094 | controller | Installing build dependencies: started 2023-08-22 05:53:58.372457 | controller | Installing build dependencies: finished with status 'done' 2023-08-22 05:53:58.373282 | controller | Getting requirements to build wheel: started 2023-08-22 05:53:58.680407 | controller | Getting requirements to build wheel: finished with status 'error' 2023-08-22 05:53:58.689654 | controller | error: subprocess-exited-with-error (https://b3e35e76f7fc3e0cf6b5-d430d94f79a1de67219002b64dcf7484.ssl.cf1.rackcdn.com/1904/63f02a9c37ef75f9dcf25159fb4033d6edf146ee/check/integration-community.aws-1/b2f8016/job-output.txt) Tries to work around this problem by pinning the PyYAML version to 5.3.1 (see also yaml/pyyaml#736). ISSUE TYPE Test Pull Request COMPONENT NAME integration tests Reviewed-by: Alina Buzachis Reviewed-by: Mark Chappell Reviewed-by: Felix Fontein <felix@fontein.de> Reviewed-by: Markus Bergholz <git@osuv.de> (cherry picked from commit 002b139)
felixfontein
added a commit
to felixfontein/community.aws
that referenced
this pull request
Aug 24, 2023
CI: Force PyYAML version that can be installed SUMMARY Currently integration tests with ansible/ansible-zuul-jobs#1816 still fail when installing some requirements: 2023-08-22 05:53:46.350742 | TASK [ansible-test : Install python requirements] [...] 2023-08-22 05:53:53.860850 | controller | Collecting PyYAML<5.5,>=3.10 (from awscli->-r /home/zuul-worker/.ansible/collections/ansible_collections/community/aws/test-requirements.txt (line 19)) 2023-08-22 05:53:53.866271 | controller | Downloading PyYAML-5.4.1.tar.gz (175 kB) 2023-08-22 05:53:53.878160 | controller | �������������������������������������� 175.1/175.1 kB 19.0 MB/s eta 0:00:00 2023-08-22 05:53:54.065094 | controller | Installing build dependencies: started 2023-08-22 05:53:58.372457 | controller | Installing build dependencies: finished with status 'done' 2023-08-22 05:53:58.373282 | controller | Getting requirements to build wheel: started 2023-08-22 05:53:58.680407 | controller | Getting requirements to build wheel: finished with status 'error' 2023-08-22 05:53:58.689654 | controller | error: subprocess-exited-with-error (https://b3e35e76f7fc3e0cf6b5-d430d94f79a1de67219002b64dcf7484.ssl.cf1.rackcdn.com/1904/63f02a9c37ef75f9dcf25159fb4033d6edf146ee/check/integration-community.aws-1/b2f8016/job-output.txt) Tries to work around this problem by pinning the PyYAML version to 5.3.1 (see also yaml/pyyaml#736). ISSUE TYPE Test Pull Request COMPONENT NAME integration tests Reviewed-by: Alina Buzachis Reviewed-by: Mark Chappell Reviewed-by: Felix Fontein <felix@fontein.de> Reviewed-by: Markus Bergholz <git@osuv.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AWS Integration tests run against Ansible "milestone". The milestone release has been updated and dropped support for Python 3.9 on controllers, and as such we need to bump the version we're running integration tests against.