Skip to content

Commit

Permalink
Accept any string for "network_mode" in molecule.json schema (#3725)
Browse files Browse the repository at this point in the history
* accept any string for network mode

* keep enum

* rm default from enum

* defautl is a so called "common" value

* use "foo" instead of "service: vpn"
  • Loading branch information
fredlev authored Nov 6, 2022
1 parent ee1e927 commit bc0659a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
5 changes: 0 additions & 5 deletions src/molecule/data/molecule.json
Original file line number Diff line number Diff line change
Expand Up @@ -229,11 +229,6 @@
"type": "string"
},
{
"pattern": "^service:[a-zA-Z0-9:_.\\\\-]+$",
"type": "string"
},
{
"pattern": "^container:[a-zA-Z0-9][a-zA-Z0-9_.-]+$",
"type": "string"
}
],
Expand Down
2 changes: 1 addition & 1 deletion tools/test-schema/test/molecule/default/molecule.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ platforms:
- /etc/ci/mirror_info.sh:/etc/ci/mirror_info.sh:ro
- /etc/pki/rpm-gpg:/etc/pki/rpm-gpg
- /sys/fs/cgroup:/sys/fs/cgroup:ro
network_mode: service:vpn
network_mode: foo
privileged: true
environment: &env
http_proxy: "{{ lookup('env', 'http_proxy') }}"
Expand Down

0 comments on commit bc0659a

Please sign in to comment.