Accept any string for "network_mode" in molecule.json schema #3725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredflev
requested review from
ziegenberg,
odyssey4me,
ganeshrn,
trishnaguha and
cidrblock
and removed request for
a team
ssbarnea
requested changes
Nov 3, 2022
There was a problem hiding this comment.
- Remove regex checks, but not enun
- Add another plain string option, after enum
- Add a test inside https://github.com/ansible-community/molecule/tree/main/tools/test-schema that would check that "foo" string is allowed, so we do not endup with regressions in the future.
Enum should stay because it is the trick used to allow auto-complete to work on that field for most common values.
fredflev
requested review from
ssbarnea
and removed request for
ziegenberg,
odyssey4me,
ganeshrn,
trishnaguha and
cidrblock
ssbarnea
approved these changes
Nov 4, 2022
davedittrich
pushed a commit
to davedittrich/molecule
that referenced
this pull request
Dec 4, 2022
…#3725) * accept any string for network mode * keep enum * rm default from enum * defautl is a so called "common" value * use "foo" instead of "service: vpn"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by @felixfontein in #3724
network_modecan be any network name specified by a user and should not be limited to a specific set of strings or string patterns.