-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update Angular v17 #606
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MunMunMiao
force-pushed
the
feat/angular_v17
branch
2 times, most recently
from
November 7, 2023 07:27
f49a4e9
to
4025cdc
Compare
Please help repair the node version |
MunMunMiao
force-pushed
the
feat/angular_v17
branch
from
November 8, 2023 02:10
d94254b
to
06cc720
Compare
MunMunMiao
force-pushed
the
feat/angular_v17
branch
from
November 9, 2023 01:01
5324ff5
to
45c0e37
Compare
simplejason
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
simplejason
reviewed
Nov 9, 2023
simplejason
reviewed
Nov 9, 2023
MunMunMiao
force-pushed
the
feat/angular_v17
branch
from
November 9, 2023 08:54
45c0e37
to
d948ff5
Compare
simplejason
reviewed
Nov 9, 2023
MunMunMiao
force-pushed
the
feat/angular_v17
branch
from
November 9, 2023 09:00
d948ff5
to
2265c30
Compare
MunMunMiao
force-pushed
the
feat/angular_v17
branch
from
November 9, 2023 09:19
2265c30
to
49e29ae
Compare
@simplejason could you merge please this PR, then i will migrate the version to Angular 18 if you are agree @simplejason do you have any idee when this pr will be merge, then i could work on compatibility with angular 18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.