Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Angular v17 #606

Merged
merged 1 commit into from
May 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ version: 2.1
references:
container_config: &container_config
docker:
- image: cimg/node:16.20.0-browsers
- image: cimg/node:20.9.0-browsers
simplejason marked this conversation as resolved.
Show resolved Hide resolved
working_directory: ~/ant-design-icons

attach_workspace: &attach_workspace
Expand Down Expand Up @@ -44,6 +44,7 @@ jobs:
- run: node -v
- run: yarn -v
- run: yarn
- run: yarn config set ignore-engines true
- run: yarn bootstrap
- run:
command: |
Expand Down Expand Up @@ -77,7 +78,7 @@ jobs:
- checkout
- *attach_workspace
- run: yarn react:ci

icons-angular:
<<: *container_config
steps:
Expand Down
6 changes: 3 additions & 3 deletions packages/icons-angular/angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,11 @@
"serve": {
"builder": "@angular-devkit/build-angular:dev-server",
"options": {
"browserTarget": "examples:build"
"buildTarget": "examples:build"
},
"configurations": {
"production": {
"browserTarget": "examples:build:production"
"buildTarget": "examples:build:production"
}
}
},
Expand All @@ -85,7 +85,7 @@
"extract-i18n": {
"builder": "@angular-devkit/build-angular:extract-i18n",
"options": {
"browserTarget": "examples:build"
"buildTarget": "examples:build"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/icons-angular/examples/app/app.component.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<h1>@ant-design/icons-angular</h1>
<h1>&#64;ant-design/icons-angular</h1>

<h2>Ant Design Icons</h2>

Expand Down
46 changes: 23 additions & 23 deletions packages/icons-angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,36 +16,36 @@
"license": "MIT",
"private": true,
"dependencies": {
"@angular/common": "^16.0.0",
"@angular/core": "^16.0.0",
"@angular/common": "^17.0.1",
simplejason marked this conversation as resolved.
Show resolved Hide resolved
"@angular/core": "^17.0.1",
"@ant-design/colors": "^7.0.0"
},
"devDependencies": {
"@angular-devkit/build-angular": "^16.0.0",
"@angular-eslint/builder": "^16.0.0",
"@angular-eslint/eslint-plugin": "^16.0.0",
"@angular-eslint/eslint-plugin-template": "^16.0.0",
"@angular-eslint/schematics": "^16.0.0",
"@angular-eslint/template-parser": "^16.0.0",
"@angular/animations": "^16.0.0",
"@angular/cli": "^16.0.0",
"@angular/compiler": "^16.0.0",
"@angular/compiler-cli": "^16.0.0",
"@angular/forms": "^16.0.0",
"@angular/language-service": "^16.0.0",
"@angular/platform-browser": "^16.0.0",
"@angular/platform-browser-dynamic": "^16.0.0",
"@angular/router": "^16.0.0",
"@angular-devkit/build-angular": "^17.0.0",
"@angular-eslint/builder": "^17.0.0",
"@angular-eslint/eslint-plugin": "^17.0.0",
"@angular-eslint/eslint-plugin-template": "^17.0.0",
"@angular-eslint/schematics": "^17.0.0",
"@angular-eslint/template-parser": "^17.0.0",
"@angular/animations": "^17.0.1",
"@angular/cli": "^17.0.0",
"@angular/compiler": "^17.0.1",
"@angular/compiler-cli": "^17.0.1",
"@angular/forms": "^17.0.1",
"@angular/language-service": "^17.0.1",
"@angular/platform-browser": "^17.0.1",
"@angular/platform-browser-dynamic": "^17.0.1",
"@angular/router": "^17.0.1",
"@ant-design/icons-svg": "^4.0.0",
"@types/jasmine": "~3.6.0",
"@types/jasminewd2": "~2.0.3",
"@types/lodash": "^4.14.136",
"@types/node": "^13.9.3",
"@typescript-eslint/eslint-plugin": "^5.59.2",
"@typescript-eslint/parser": "^5.59.2",
"@typescript-eslint/eslint-plugin": "^6.10.0",
"@typescript-eslint/parser": "^6.10.0",
"classlist": "^2.0.0",
"cross-env": "^5.2.0",
"eslint": "^8.39.0",
"eslint": "^8.53.0",
"fs-extra": "^7.0.0",
"globby": "^8.0.1",
"jasmine-core": "^4.6.0",
Expand All @@ -57,11 +57,11 @@
"karma-jasmine-html-reporter": "^2.0.0",
"karma-spec-reporter": "^0.0.36",
"lodash": "^4.17.11",
"ng-packagr": "^16.0.0",
"ng-packagr": "^17.0.0",
"prettier": "^2.8.8",
"rxjs": "^7.8.0",
"ts-node": "~10.9.0",
"typescript": "~5.0.4",
"zone.js": "~0.13.0"
"typescript": "~5.2.2",
"zone.js": "~0.14.2"
}
}
3 changes: 2 additions & 1 deletion packages/icons-angular/src/component/icon.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { AccountBookFill, AccountBookOutline, AccountBookTwoTone } from '../icon
import { IconDirective } from './icon.directive';
import { IconModule } from './icon.module';
import { IconService } from './icon.service';
import { ThemeType } from '@ant-design/icons-angular'

const staticImportIcons = [
AccountBookFill, AccountBookOutline, AccountBookTwoTone
Expand Down Expand Up @@ -198,5 +199,5 @@ describe('@ant-design/icons-angular', () => {
})
export class IconTestComponent {
type = 'account-book';
theme = 'fill';
theme: ThemeType = 'fill';
}
11 changes: 6 additions & 5 deletions packages/icons-angular/src/package.json
Original file line number Diff line number Diff line change
@@ -1,20 +1,21 @@
{
"name": "@ant-design/icons-angular",
"version": "16.0.0",
"version": "17.0.0",
"license": "MIT",
"repository": "https://github.com/ant-design/ant-design-icons/tree/master/packages/icons-angular",
"contributors": [
simplejason marked this conversation as resolved.
Show resolved Hide resolved
"Wendell Hu <wendellhu95@gmail.com>",
"Jørn Are Hatlelid <jornare@fronthouse.no>"
"Jørn Are Hatlelid <jornare@fronthouse.no>",
"MunMunMiao <wunonglin@gmail.com>"
],
"dependencies": {
"@ant-design/colors": "^7.0.0",
"tslib": "^2.0.0"
},
"peerDependencies": {
"@angular/common": "^16.0.0",
"@angular/core": "^16.0.0",
"@angular/platform-browser": "^16.0.0",
"@angular/common": "^17.0.0",
"@angular/core": "^17.0.0",
"@angular/platform-browser": "^17.0.0",
"rxjs": "^6.4.0 || ^7.4.0"
}
}