Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention component does not have 'disabled' prop #5175

Closed
jch254 opened this issue Mar 5, 2017 · 6 comments · Fixed by react-component/editor-core#4 or #6004
Closed

Mention component does not have 'disabled' prop #5175

jch254 opened this issue Mar 5, 2017 · 6 comments · Fixed by react-component/editor-core#4 or #6004
Assignees
@RaoHai
Labels
Accept You are right, we should do that help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@jch254
Copy link
Contributor

jch254 commented Mar 5, 2017

Environment

  • antd version: 2.7.4
  • OS and its version: macOS Sierra v10.12.3
  • Browser and its version: Google Chrome v56.0.2924.87

What did you expect?

Mention component should have a disabled prop - this is important for use in forms.

What happened?

Mention component does not have disabled prop.

Re-producible online demo

https://ant.design/components/mention/#API
@afc163 afc163 mentioned this issue Mar 24, 2017
Closed
@422809585mls
Copy link

没懂 有解决吗

@afc163 afc163 added Accept You are right, we should do that Enhancement help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. labels Mar 24, 2017
@afc163
Copy link
Member

afc163 commented Mar 24, 2017

@422809585mls Yep.

@afc163
Copy link
Member

afc163 commented Mar 24, 2017

Don't create duplicate issue if someone else already created one.

This was referenced Mar 27, 2017
Merged
Closed
@benjycui
Copy link
Contributor

benjycui commented May 3, 2017

@RaoHai disabled 应该还需要样式配合？

@RaoHai
Copy link
Contributor

RaoHai commented May 3, 2017 •
edited
Loading

样式在 antd 里搞。待会我发一个大 PR。

@afc163 afc163 reopened this May 3, 2017
RaoHai added a commit to RaoHai/ant-design that referenced this issue May 3, 2017
@RaoHai
Improvements of Mention
e13dcd2 
 #### FEATURES

 * use `ContentState` instead of `EditorState`, selection events won't trigger
   onChange anymore.
 * deprecated `Mention.toEditorState`, instead of `Mention.toContentState`,
 * `Mention.toEditorState` are compatibled, but have a warnning in console.

 #### ISSUES

 * `disabled` and `readOnly` props supported.
 * fixed controlled mode bug.

 * close ant-design#5788
 * close ant-design#5175
 * close #react-component/editor-mention#7
@RaoHai RaoHai mentioned this issue May 3, 2017
Merged
benjycui pushed a commit that referenced this issue May 5, 2017
@RaoHai @benjycui
feat: support Mention[disabled|readOnly] and add some warning(#6004)
4518b02 
#### FEATURES

 * use `ContentState` instead of `EditorState`, selection events won't trigger
   onChange anymore.
 * deprecated `Mention.toEditorState`, instead of `Mention.toContentState`,
 * `Mention.toEditorState` are compatibled, but have a warnning in console.

 #### ISSUES

 * `disabled` and `readOnly` props supported.
 * fixed controlled mode bug.

 * close #5788
 * close #5175
 * close #react-component/editor-mention#7
@lock
Copy link

lock bot commented May 5, 2018

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RaoHai RaoHai

Labels
Accept You are right, we should do that help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Milestone
No milestone
5 participants
@afc163 @RaoHai @benjycui @jch254 @422809585mls