Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose 'readOnly' props #7

Closed
wants to merge 1 commit into from

Conversation

william-yz
Copy link

RaoHai added a commit to RaoHai/ant-design that referenced this pull request May 3, 2017
 #### FEATURES

 * use `ContentState` instead of `EditorState`, selection events won't trigger
   onChange anymore.
 * deprecated `Mention.toEditorState`, instead of `Mention.toContentState`,
 * `Mention.toEditorState` are compatibled, but have a warnning in console.

 #### ISSUES

 * `disabled` and `readOnly` props supported.
 * fixed controlled mode bug.

 * close ant-design#5788
 * close ant-design#5175
 * close #react-component/editor-mention#7
@benjycui
Copy link
Member

benjycui commented May 5, 2017

这个 PR 不需要的话,就关掉? @RaoHai

benjycui pushed a commit to ant-design/ant-design that referenced this pull request May 5, 2017
#### FEATURES

 * use `ContentState` instead of `EditorState`, selection events won't trigger
   onChange anymore.
 * deprecated `Mention.toEditorState`, instead of `Mention.toContentState`,
 * `Mention.toEditorState` are compatibled, but have a warnning in console.

 #### ISSUES

 * `disabled` and `readOnly` props supported.
 * fixed controlled mode bug.

 * close #5788
 * close #5175
 * close #react-component/editor-mention#7
@MrPeak
Copy link
Contributor

MrPeak commented Sep 25, 2017

@afc163 This feature has been implemented. ant-design/ant-design@4518b02

@MrPeak
Copy link
Contributor

MrPeak commented Sep 25, 2017

Additional modifications may affect the functionality of AntD itself...

@afc163
Copy link
Member

afc163 commented Sep 25, 2017

👌 It can be closed.

@afc163 afc163 closed this Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention component does not have 'disabled' prop
5 participants